-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protective Monitoring: Integration #6163
Comments
Route53 logs are also in cloudwatch, so we might want to do one of the other cloudwatch integrations first, then when we start to do route53 we will have the knowledge of the cloudwatch integration already so it may help decide which method is better. |
Hi @SimonPPledger. Just so I'm clear, this would cover us exporting log information into a remote tool? We can do that for the VPC flow logs with a little bit of coordination with the requestor. For Route53 I'd need to know exactly what they're after. There are a few different kinds of Route 53 logs - resolve log queries and public dns queries are the sort of thing I'd assume the requestor would want. Likewise I'm confident we can give them the Network Firewall logs they're after, but it's worth understanding what kind of granularity they want from the logs. They may, for example, want logs for traffic that we deny (but do not log at present). |
I've been through and identified the following resources that are relevant:
I'm out tomorrow morning so I'll talk to @dms1981 to confirm this scope is correct. |
Spoke to Leo via slack. Short initial chat organised for tomorrow at 2.30pm |
Content of email from Leo:
Also:
|
Questions:
|
Email from Leo as a follow up to the meeting:
|
PR with the initial set of changes for firehose - ministryofjustice/modernisation-platform-terraform-member-vpc#328 SecOps have granted us access to the security keys and added manually a secrets manager resource in core-vpc-development to hold the key for their preprod network endpoint. |
Both https://github.com/ministryofjustice/modernisation-platform/tree/adds-firehose-resources and https://github.com/ministryofjustice/modernisation-platform-terraform-member-vpc/tree/add-aws-firehose are producing a clean plan. Next steps:
|
Working build in core-vpc-sandbox - https://github.com/ministryofjustice/modernisation-platform-terraform-member-vpc/tree/add-aws-firehose Next step to identify the scope of what's needed to apply to development. |
Note: This is from the plan & shows that property in question is deprecated however the terraform documentation shows otherwise - https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_subscription_filter |
Latest PR of the module - ministryofjustice/modernisation-platform-terraform-member-vpc#338. We still use the build_firehose variable as this determines which environ ments the resources are built in or not. |
New release for the VPC module -https://github.com/ministryofjustice/modernisation-platform-terraform-member-vpc/releases/tag/v2.3.0 |
PR for the modernisation-platform repo changes - #6449 |
PR applied and resources built in dev & production. Will clear down sandbox before end of today. |
Sandbox cleared. |
PR for the 2nd part of the changes - #6485 |
PR for secret - #6505. This single secret will hold all of the endpoint and key details. |
New commit that covers a just the firewall inspection logs & review comments. |
Firewall inspection log data now being transferred. Tomorrow will be looking at the firewall vpc flow log transfers - which will not take long, and then we can move onto R53 data. |
PR applied for the firewall vpc flow log data - #6545 |
Chat with Leo at 12.30 to go through the R53 records. |
Additional VPC flow logs: core-logging - 2 vpcs - see branch link below. For each of the above:
A single iteration of the module creates 19 resources. https://github.com/ministryofjustice/modernisation-platform/tree/firehose-additional-vpcs any others? Modernisation has just default vpc. Accounts that don't use shared vpcs such as bichard7? |
Meeting with Leo:
|
Tidied up the added data & locals in core-vpc to reduce the number of items used. |
We have added the transfer of R53 resolver logs & have confirmed they are transmitting. We need to trigger a small update to the firewall inspection & flow logs plus those for shared so the module changes are applied. Once that is done, we will create a new ticket for the cloudtrail logs as that is a new requirement that wasn't covered in the original scope. |
Had a final chat with Leo before he goes on leave. Summarised where we are:
He knows that the cloudtrail events are being covered in a separate ticket. Also he mentioned to contact this team - monitoring-and-integration-platform@justice.gov.uk - if anything changes. Leo is back on Wednesday next week. |
Cloudtrail integration discussed in #6614 |
User Story
As a product manager
I need to ensure that we have an appropriate level of protective monitoring
So that we have as secure a service as possible.
This ticket is to work with the protective monitoring team to capture the following levels of detail - for PRODUCTION only.
We are looking to provide the following info:
VPC flow logs
Networking live data
Network Firewall logs
Route 53
First step will me a conversation with Leo
Value / Purpose
This is to help security highlight issues
Useful Contacts
leonardo.marini@justice.gov.uk
Additional Information
For the integration work:
Route 53 - this should just require a configuration change in route 53
We then need to get the following 2 logs into a singel group in the tool (see below for previously used terraform):
This is the terraform code used by the LAN team.
module
Proposal / Unknowns
No response
Definition of Done
The text was updated successfully, but these errors were encountered: