Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6114. #359

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Issue #6114. #359

merged 4 commits into from
Feb 6, 2024

Conversation

mikereiddigital
Copy link
Contributor

@mikereiddigital mikereiddigital commented Feb 5, 2024

Removes "bucket_versioning & "bucket_force_destroy" variables as per issue ministryofjustice/modernisation-platform#6114.

Unit test runs clean.

@mikereiddigital mikereiddigital requested a review from a team as a code owner February 5, 2024 15:46
Copy link
Contributor

github-actions bot commented Feb 5, 2024

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:
.


Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 184.875µs
parsing 600.524426ms
adaptation 559.209µs
checks 8.67748ms
total 609.94599ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 102
files read 8

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-05 15:48:32,113 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 77, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

Trivy Scan

Show Output

Copy link
Contributor

github-actions bot commented Feb 5, 2024

TFSEC Scan Success

Show Output ```hcl

TFSEC will check the following folders:
.


Running TFSEC in .
Excluding the following checks: AWS089, AWS099, AWS009, AWS007, AWS002

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available
for the time being, although our engineering
attention will be directed at Trivy going forward.

You can read more here:
aquasecurity/tfsec#1994

timings
──────────────────────────────────────────
disk i/o 205.32µs
parsing 362.652074ms
adaptation 568.829µs
checks 3.333343ms
total 366.759566ms

counts
──────────────────────────────────────────
modules downloaded 1
modules processed 2
blocks processed 102
files read 8

results
──────────────────────────────────────────
passed 16
ignored 44
critical 0
high 0
medium 0
low 0

No problems detected!

tfsec_exitcode=0

</details> #### `Checkov Scan` Success
<details><summary>Show Output</summary>

```hcl

*****************************

Checkov will check the following folders:
.

*****************************

Running Checkov in .
Excluding the following checks: CKV_AWS_144,CKV_AWS_18
2024-02-05 15:53:29,257 [MainThread  ] [WARNI]  Failed to download module github.com/ministryofjustice/modernisation-platform-terraform-s3-bucket?ref=568694e50e03630d99cb569eafa06a0b879a1239:None (for external modules, the --download-external-modules flag is required)
terraform scan results:

Passed checks: 77, Failed checks: 0, Skipped checks: 0

github_actions scan results:

Passed checks: 176, Failed checks: 0, Skipped checks: 0


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing "terraform" plugin...
Installed "terraform" (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.5.0)
tflint will check the following folders:
.

*****************************

Running tflint in .
tflint_exitcode=0

Trivy Scan

Show Output

@mikereiddigital mikereiddigital merged commit 4ef702f into main Feb 6, 2024
2 checks passed
@mikereiddigital mikereiddigital deleted the issue/6114 branch February 6, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants