Bug: Remove bucket_versioning and bucket_force_destroy from bastion linux module

[davidkelliott]

Expected Behavior

TFlint is failing because bucket_versioning and bucket_force_destroy are declared but not used:
https://github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux/actions/runs/7742030400/job/21110231383?pr=350

Actual Behavior

These should be removed from the module, please note this is a breaking change, and the environments repo will need to be updated to remove references to these variables.

Steps to Reproduce the Problem

1. Run TFlint in the module

Version

No response

Modules

No response

Account

No response

[mikereiddigital]

Draft PR with the changes made. The unit test is failing due to the max number of s3 buckets being exceeded in testing-test. Looking into why these buckets are not being cleared down by the weekly nuke.

[mikereiddigital]

Unit Test has run after removing some of the 100+ buckets in testing-test and clearing down IAM resources that had not been created by previous runs but which had not been cleared. Will now complete the PR and create a new release.

[mikereiddigital]

New release of module - https://github.com/ministryofjustice/modernisation-platform-terraform-bastion-linux/releases/tag/v4.1.2