Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install: initialize admin and legacy client to avoid crash for dry-run mode #937

Merged
merged 2 commits into from
Aug 30, 2024
Merged

install: initialize admin and legacy client to avoid crash for dry-run mode #937

merged 2 commits into from
Aug 30, 2024

Commits on Aug 29, 2024

  1. fix: panic in dry-run mode kubectl directpv install -o yaml 

    ```
main.installMain({0x1dbf3e0, 0xc000486c30})
	github.com/minio/directpv/cmd/kubectl-directpv/install.go:194 +0x5bd
main.init.func9(0x2b62700?, {0xc000402360?, 0x0?, 0x9?})
	github.com/minio/directpv/cmd/kubectl-directpv/install.go:100 +0x25
github.com/spf13/cobra.(*Command).execute(0x2b62700, {0xc0004022d0, 0x9, 0x9})
	github.com/spf13/cobra@v1.8.1/command.go:989 +0xab1
github.com/spf13/cobra.(*Command).ExecuteC(0x2b63560)
	github.com/spf13/cobra@v1.8.1/command.go:1117 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
	github.com/spf13/cobra@v1.8.1/command.go:1041
github.com/spf13/cobra.(*Command).ExecuteContext(...)
	github.com/spf13/cobra@v1.8.1/command.go:1034
main.main()
	github.com/minio/directpv/cmd/kubectl-directpv/main.go:193 +0x14e
```
    @Praveenrajmani
    Praveenrajmani committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    cf3bfd0 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-dry-run

    @balamurugana
    balamurugana committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    de68c3e View commit details
    Browse the repository at this point in the history