install: initialize admin and legacy client to avoid crash for dry-run mode #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Praveenrajmani
commented
Aug 28, 2024
Praveenrajmani
commented
```
main.installMain({0x1dbf3e0, 0xc000486c30})
github.com/minio/directpv/cmd/kubectl-directpv/install.go:194 +0x5bd
main.init.func9(0x2b62700?, {0xc000402360?, 0x0?, 0x9?})
github.com/minio/directpv/cmd/kubectl-directpv/install.go:100 +0x25
github.com/spf13/cobra.(*Command).execute(0x2b62700, {0xc0004022d0, 0x9, 0x9})
github.com/spf13/cobra@v1.8.1/command.go:989 +0xab1
github.com/spf13/cobra.(*Command).ExecuteC(0x2b63560)
github.com/spf13/cobra@v1.8.1/command.go:1117 +0x3ff
github.com/spf13/cobra.(*Command).Execute(...)
github.com/spf13/cobra@v1.8.1/command.go:1041
github.com/spf13/cobra.(*Command).ExecuteContext(...)
github.com/spf13/cobra@v1.8.1/command.go:1034
main.main()
github.com/minio/directpv/cmd/kubectl-directpv/main.go:193 +0x14e
```
Praveenrajmani
force-pushed
the
fix-dry-run
branch
from
a1f5e77
to
cf3bfd0
Compare
balamurugana
approved these changes
Aug 29, 2024
balamurugana
changed the title
kubectl directpv install -o yaml
balamurugana
added a commit
to balamurugana/directpv
that referenced
this pull request
Sep 5, 2024
…n mode (minio#937) ``` main.installMain({0x1dbf3e0, 0xc000486c30}) github.com/minio/directpv/cmd/kubectl-directpv/install.go:194 +0x5bd main.init.func9(0x2b62700?, {0xc000402360?, 0x0?, 0x9?}) github.com/minio/directpv/cmd/kubectl-directpv/install.go:100 +0x25 github.com/spf13/cobra.(*Command).execute(0x2b62700, {0xc0004022d0, 0x9, 0x9}) github.com/spf13/cobra@v1.8.1/command.go:989 +0xab1 github.com/spf13/cobra.(*Command).ExecuteC(0x2b63560) github.com/spf13/cobra@v1.8.1/command.go:1117 +0x3ff github.com/spf13/cobra.(*Command).Execute(...) github.com/spf13/cobra@v1.8.1/command.go:1041 github.com/spf13/cobra.(*Command).ExecuteContext(...) github.com/spf13/cobra@v1.8.1/command.go:1034 main.main() github.com/minio/directpv/cmd/kubectl-directpv/main.go:193 +0x14e ``` Co-authored-by: Bala FA <bala@minio.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.