Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not apply distinct if no regular filters have been found. #73

Merged
merged 2 commits into from
Dec 6, 2018
Merged

Do not apply distinct if no regular filters have been found. #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
474e314
Do not apply distinct if no regular filters have been found.
simone-divitel Dec 6, 2018
7cec865
added Simone Pellizzari to authors
miki725 Dec 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion AUTHORS.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ Contributors
* Håken Lid - https://github.com/haakenlid
* Ryan O’Hara - https://github.com/ryan-copperleaf
* webrunners - https://github.com/webrunners

* Simone Pellizzari - https://github.com/simone6021
2 changes: 1 addition & 1 deletion url_filter/backends/django.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ def filter_by_specs(self, queryset):
queryset = queryset.exclude(**{lookup: value})

to_many = self._is_any_to_many()
return queryset.distinct() if to_many else queryset
return queryset.distinct() if to_many and (include or exclude) else queryset

def _is_any_to_many(self):
return any(self._is_to_many(self.model, i.components) for i in self.regular_specs)
Expand Down