Do not apply distinct if no regular filters have been found. #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops. Thanks for the fix. |
|
0.3.11 was released |
|
Hello,
thanks for your nice piece of software and for accepting my contribution.
I am planning to contribute more when i find some time..
Best regards,
Simone
… Il 6 dicembre 2018 alle 18.54 Miroslav Shubernetskiy ***@***.***> ha scritto:
Oops. Thanks for the fix.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub #73 (comment) , or mute the thread https://github.com/notifications/unsubscribe-auth/AOnvU2-4IWg48BUv5PDE8b2Q3xuDbMrzks5u2VnlgaJpZM4ZGjWv .
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Queryset should not be modified if no filters are applied to it.
The concrete use case is usage of url filter with drf bulk (which i did not remember that was yours, thanks also for that piece of code!), since the latter makes a security checks when bulk deleting: it will not execute if the queryset has not been filtered in order to avoid accidental deletion of all records.