Fix --write-metadata option to support extractors with datetime metadata
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a GalleryDLJSONEncoder to encode datetime.datetime as ISO 8601 strings.
|
JFTR, the test failures/errors seems unrelated to this change. Here relevant output: |
mikf
added a commit
that referenced
this pull request
May 9, 2019
Simplified universal serialization support in json.dump() can be achieved by passing 'default=str', which was already the case in DataJob.run() for -j/--dump-json, but not for the 'metadata' post-processor. This commit introduces util.dump_json() that (more or less) unifies the JSON output procedure of both --write-metadata and --dump-json. (#251, #252)
|
Thanks for your quick fix, but I'd rather solve this in a slightly different way. Adding a whole JSONEncoder subclass is kind of overkill when passing |
|
Hello Mike,
Mike Fährmann writes:
Thanks for your quick fix, but I'd rather solve this in a slightly different way.
Adding a whole JSONEncoder subclass is kind of overkill when passing `default=str` to json.dump() does pretty much the some thing. This was already done in the other place where JSON output happens, but for some reason not in the `metadata` post-processor. I've now added a function that gets used in both places, so they should behave the same (523ebc9).
Yes, I agree, that's better and simpler, thank you!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
--write-metadataoption with extractors that havedatetimemetadatagallery-dlfails to encode JSON because json.dump() cannot serialize them, e.g.:
This pull request introduce a GalleryDLJSONEncoder that serialize
datetime.datetime objects as ISO 8601 strings.
In the future - if needed - this can be extended to support more
non-basic types.