-
-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"write-metadata" not working for deviantart #252
Labels
Comments
Hello Rene,
Rene Ranzinger writes:
Using the following command:
`gallery-dl.exe -u xxx -p xxx --write-metadata --verbose https://www.deviantart.com/cryptid-creations `
This error happens:
[...]
[deviantart][debug]
Traceback (most recent call last):
File "gallery_dl\job.py", line 55, in run
File "gallery_dl\job.py", line 99, in dispatch
File "gallery_dl\job.py", line 230, in handle_url
File "gallery_dl\postprocessor\metadata.py", line 40, in run
File "gallery_dl\postprocessor\metadata.py", line 69, in _write_json
File "json\__init__.py", line 179, in dump
File "json\encoder.py", line 431, in _iterencode
File "json\encoder.py", line 405, in _iterencode_dict
File "json\encoder.py", line 438, in _iterencode
File "json\encoder.py", line 179, in default
TypeError: Object of type datetime is not JSON serializable
`
[...]
Pull request #251 is a possible fix for it (the problem is not specific to `deviantart` extractor but to extractors that have `datetime` in metadata).
|
mikf
added a commit
that referenced
this issue
May 9, 2019
Simplified universal serialization support in json.dump() can be achieved by passing 'default=str', which was already the case in DataJob.run() for -j/--dump-json, but not for the 'metadata' post-processor. This commit introduces util.dump_json() that (more or less) unifies the JSON output procedure of both --write-metadata and --dump-json. (#251, #252)
Thanks for the quick fix. I am actual not a Python guy and only use the Windows compilation. Do you know when you plan to make the next release version?
Best,
René
________________________________________
From: Leonardo Taccari <notifications@github.com>
Sent: Thursday, May 9, 2019 4:08:54 AM
To: mikf/gallery-dl
Cc: Rene Ranzinger; Author
Subject: Re: [mikf/gallery-dl] "write-metadata" not working for deviantart (#252)
Hello Rene,
Rene Ranzinger writes:
Using the following command:
`gallery-dl.exe -u xxx -p xxx --write-metadata --verbose https://www.deviantart.com/cryptid-creations `
This error happens:
[...]
[deviantart][debug]
Traceback (most recent call last):
File "gallery_dl\job.py", line 55, in run
File "gallery_dl\job.py", line 99, in dispatch
File "gallery_dl\job.py", line 230, in handle_url
File "gallery_dl\postprocessor\metadata.py", line 40, in run
File "gallery_dl\postprocessor\metadata.py", line 69, in _write_json
File "json\__init__.py", line 179, in dump
File "json\encoder.py", line 431, in _iterencode
File "json\encoder.py", line 405, in _iterencode_dict
File "json\encoder.py", line 438, in _iterencode
File "json\encoder.py", line 179, in default
TypeError: Object of type datetime is not JSON serializable
`
[...]
Pull request #251 contain a possible fix for it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#252 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AARJT6B37OJZ23BUUPVNE6LPUPLZNANCNFSM4HLW55YA>.
|
The next "regular" release would be Friday next week, but I can do one this weekend as well. As a side note: |
Thanks for the OAuth hint. I will have to look into this more. Just starting to explore the configuration file.
Release: If you can make a new release that is appreciated but I can also wait one more week.
…________________________________________
From: Mike Fährmann <notifications@github.com>
Sent: Thursday, May 9, 2019 11:33:37 AM
To: mikf/gallery-dl
Cc: Rene Ranzinger; Author
Subject: Re: [mikf/gallery-dl] "write-metadata" not working for deviantart (#252)
Do you know when you plan to make the next release version?
The next "regular" release would be Friday next week, but I can do one this weekend.
As a side note: -u and -p have no effect for DeviantArt. You need to use OAuth<https://github.com/mikf/gallery-dl#oauth> if you want to be "logged in", but that is only neccessary if you want to access "private/hidden" content.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#252 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AARJT6A5D2WE4CU7GJR62ZDPUQ75DANCNFSM4HLW55YA>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using the following command:
gallery-dl.exe -u xxx -p xxx --write-metadata --verbose https://www.deviantart.com/cryptid-creations
This error happens:
The text was updated successfully, but these errors were encountered: