Bugfix :: Metatdata Season Thumbnail : Fixes bug that attempted retrieval of non-existent season 0 (Special) and skipped last season when a show lacks a season 0.

[Conjuro]

This bug was discovered by luxmoggy; see forum post.

Some show are missing thumbnails for the last season. This is because when retrieving the thumbnails a list of seasons is created using number of seasons and a range(0..n) (e.g. [0, 1, 2, 3, 4, 5]. When a show lacks a season 0, it will still create the list using the same range starting point; Thereby creating a list containing a non-existent season 0 and missing the last season ([0, 1, 2, 3, 4]).

This patch drops creating a new list in favor of using the already existing list.

[thezoggy]

this bug was already previously found, i do believe @itofzo already fixed it in his fork, may want to review his code:
https://github.com/itofzo/Sick-Beard/commits/all_fixes_dev/sickbeard/metadata/generic.py

[Conjuro]

Thanks @thezoggy. Reviewed his code and it does indeed fix the bug while also preventing excess downloads.

Also found that my patch duplicates pull request #386 by @hmflash. Though I believe mine to be a better solution.

In my opinion, pull #409 from @itofzo and close this and #386. Otherwise pull this one and close #386.

Leaving this pull open until #409 or other gets pulled.

[Conjuro]

Rebased for current development branch. Still recommend PR 409 from itofzo.

[thezoggy]

if you recommend itofzo's pr.. why this one? have you compared the two ?

[Conjuro]

Yes, I reviewed his code when you first pointed out that his patch existed and I found it to be more comprehensive. I left this PR open in case #409 didn't get pulled for whatever reason. Now that it's been merged I'm closing this PR.

[thezoggy]

ty