Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix season tumbnails always downloading #409

Merged
merged 2 commits into from Jun 12, 2013
Merged

Fix season tumbnails always downloading #409

merged 2 commits into from Jun 12, 2013

Conversation

ghost
Copy link

@ghost ghost commented Jun 9, 2012

Check first if there are already season thumbnails.

Otherwise if you have already season thumbs, it downloads them anyway.
Finds out the imagefile already exists and not write them.

@@ -445,6 +445,9 @@ def save_season_thumbs(self, show_obj):
# to present to user via ui to pick down the road.
for cur_season in season_dict:

if self._has_season_thumb(show_obj, cur_season):
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be up on line 217 where the rest of the checks are - not sure why this one got missed though, thanks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried it on line 217 first, but couldn't figure out how to get 'season' there.

@ghost
Copy link
Author

ghost commented Jul 9, 2012

It's on L217 now, using show_obj.episodes.iteritems()
Guess this also 'solves' Fix an issue where season banners don't always download for the most recent season #386

midgetspy added a commit that referenced this pull request Jun 12, 2013
Fix season tumbnails always downloading
@midgetspy midgetspy merged commit c0ba7ee into midgetspy:development Jun 12, 2013
gborri pushed a commit to gborri/Sick-Beard that referenced this pull request Jul 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant