Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dependency lookup case insensitive #4866

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

JohnMcPMS
Copy link
Member

@JohnMcPMS JohnMcPMS commented Oct 10, 2024

Fixes #3679

Change

Makes the dependency lookup case insensitive.

Validation

Adds a new test that exercises adding a package with a dependency that does not match the case of the original package identifier.

Microsoft Reviewers: Open in CodeFlow

@JohnMcPMS JohnMcPMS requested a review from a team as a code owner October 10, 2024 22:32
@Trenly
Copy link
Contributor

Trenly commented Oct 10, 2024

@microsoft-github-policy-service microsoft-github-policy-service bot added the Issue-Feature This is a feature request for the Windows Package Manager client. label Oct 10, 2024
@JohnMcPMS JohnMcPMS added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Issue-Feature This is a feature request for the Windows Package Manager client. labels Oct 10, 2024
@JohnMcPMS JohnMcPMS merged commit 2b0aef3 into microsoft:master Oct 11, 2024
9 checks passed
@JohnMcPMS JohnMcPMS deleted the case-dep branch October 11, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependencies should be Case Insensitive
3 participants