Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies should be Case Insensitive #3679

Closed
Trenly opened this issue Sep 26, 2023 · 0 comments · Fixed by #4866
Closed

Dependencies should be Case Insensitive #3679

Trenly opened this issue Sep 26, 2023 · 0 comments · Fixed by #4866
Labels
Dependencies Related to package level dependencies In-PR Issue related to a PR Issue-Bug It either shouldn't be doing this or needs an investigation.
Milestone
1.9 Client

Comments

@Trenly
Copy link
Contributor

Trenly commented Sep 26, 2023

Description of the new feature / enhancement

When adding package dependencies, they are case sensitive. They probably don't need to be

image

Proposed technical implementation details

No response
@Trenly Trenly added the Issue-Feature This is a feature request for the Windows Package Manager client. label Sep 26, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Triage Issue need to be triaged label Sep 26, 2023
Trenly added a commit to Trenly/winget-pkgs that referenced this issue Sep 26, 2023
@Trenly
Casing Matters - microsoft/winget-cli#3679
cf1908c
@denelon denelon added Dependencies Related to package level dependencies and removed Needs-Triage Issue need to be triaged labels Sep 26, 2023
@Trenly Trenly mentioned this issue Oct 10, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR Issue related to a PR label Oct 10, 2024
@JohnMcPMS JohnMcPMS added Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Issue-Feature This is a feature request for the Windows Package Manager client. labels Oct 10, 2024
@denelon denelon added this to the 1.10 Client milestone Oct 10, 2024
JohnMcPMS added a commit that referenced this issue Oct 11, 2024
@JohnMcPMS
Make dependency lookup case insensitive (#4866)
2b0aef3 
Fixes #3679 

## Change
Makes the dependency lookup case insensitive.

## Validation
Adds a new test that exercises adding a package with a dependency that
does not match the case of the original package identifier.
@denelon denelon modified the milestones: 1.10 Client, 1.9 Client Oct 22, 2024
@denelon denelon added this to WinGet Oct 22, 2024
@denelon denelon moved this to Done in WinGet Oct 22, 2024
@denelon denelon moved this from Done to Released in WinGet Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Dependencies Related to package level dependencies In-PR Issue related to a PR Issue-Bug It either shouldn't be doing this or needs an investigation.
Projects
WinGet
Status: Released
Milestone
1.9 Client
Development

Successfully merging a pull request may close this issue.

Make dependency lookup case insensitive JohnMcPMS/winget-cli
3 participants
@JohnMcPMS @Trenly @denelon