-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move VARIANT
support to the windows
crate
#3282
Conversation
It's tricky because |
This might be a dumb question but do they need to be in a separate namespace? Or is this something that could reasonably be changed? |
Yes, that would greatly simplify this. Arguably they should just be together as the two are interdependent APIs. |
It's far from perfect but greatly simplifies |
#2786 added richer support for
VARIANT
andPROPVARIANT
and at the time the only practical way to do that was adding it to thewindows-core
crate. But that meant that everyone using thewindows-core
crate carried aroundVARIANT
support even though that's really only meant for some very old Windows APIs in thewindows
crate. Now that #3110 added a simpler way to handle type extensions, we can more naturally provide this same functionality directly in thewindows
crate, unburdening thewindows-core
crate and simplifying thewindows-metadata
andwindows-bindgen
crates as well with less "special" type support.