Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure msbuild import applies to net35 projects #194

Merged
merged 2 commits into from
Jan 29, 2021

Conversation

AArnott
Copy link
Member

@AArnott AArnott commented Jan 27, 2021

Contributes to fixing microsoft/CsWin32#68

Also use buildTransitive/ so that installation into a projection that then chains it into a customer project will retain the msbuild imports from this project.

This makes projections that depend on this package automatically get the effect of this package's build folder in receiving projects, making it more likely to work the first time they try.
@AArnott
Copy link
Member Author

AArnott commented Jan 29, 2021

I have fully tested this locally.

@AArnott AArnott merged commit 006d609 into microsoft:master Jan 29, 2021
@AArnott AArnott deleted the fix68 branch January 29, 2021 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants