Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source is not generated for .NET Framework 3.5 #68

Closed
jnm2 opened this issue Jan 26, 2021 · 1 comment · Fixed by #70
Closed

Source is not generated for .NET Framework 3.5 #68

jnm2 opened this issue Jan 26, 2021 · 1 comment · Fixed by #70
Assignees
@AArnott
Labels
bug Something isn't working

Comments

@jnm2
Copy link
Contributor

jnm2 commented Jan 26, 2021 •
edited
Loading

Is there a technical reason why a library targeting net35;net48;netcoreapp5.0-windows is adding generated source to only the net48 and netcoreapp5.0-windows compilations? I didn't spot anything in the generated source that would not work on net35.

I hoped to replace https://github.com/Techsola/InstantReplay/tree/main/src/Techsola.InstantReplay/Native.

.NET Framework 3.5 is in active support by Microsoft. Some of the projects at my day job integrate with a platform that still requires net35, unfortunately, in a place where we would really benefit from using https://github.com/Techsola/InstantReplay.

I love the generated source! This is an awesome concept!
@AArnott AArnott self-assigned this Jan 27, 2021
@AArnott AArnott added the bug Something isn't working label Jan 27, 2021
@AArnott AArnott mentioned this issue Jan 27, 2021
Merged
AArnott added a commit that referenced this issue Jan 27, 2021
@AArnott
Arrange for msbuild import to apply to pre-net40 projects
1fbbfc8 
Fixes #68
@AArnott AArnott mentioned this issue Jan 27, 2021
Merged
AArnott added a commit to AArnott/win32metadata that referenced this issue Jan 29, 2021
@AArnott
Ensure msbuild import applies to net35 projects
46b23c7 
Contributes to fixing microsoft/CsWin32#68
AArnott added a commit that referenced this issue Jan 29, 2021
@AArnott
Arrange for msbuild import to apply to pre-net40 projects
33eefac 
Fixes #68
@jnm2
Copy link
Contributor Author

jnm2 commented Feb 14, 2021

🎉 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Arrange for msbuild import to apply to pre-net40 projects microsoft/CsWin32
2 participants
@AArnott @jnm2