Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert vscode-textmate on stable #84052

Closed
wants to merge 14 commits into from
Closed

Conversation

alexdima
Copy link
Member

@alexdima alexdima commented Nov 6, 2019

This PR addresses #83541 for stable

aeschli and others added 14 commits November 1, 2019 15:43
Update Welcome Page header in web.
…correctly

In #81718 we adjusted breakpoint display logic to show an 'empty' arrow on the
line, and the arrow with a dot at the column where the debugger is running.
However, not all debuggers support column breakpoints. Bowden noticed, while
working on his Python demo for ignite, that breakpoints in Python code no
longer displayed correctly.

This PR tweaks the logic so that if we see a breakpoint that doesn't have
an associated column, we show the arrow with a dot on the line, rather than
assuming that there'll be an inline indicator arrow.
* fixes #83912

* remove any mention of mod+hover
Update xterm to avoid rendering all lines
@alexdima alexdima closed this Nov 6, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants