Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show Control Hover is not a good name for the action #83912

Closed
alexdima opened this issue Nov 4, 2019 · 3 comments
Closed

Show Control Hover is not a good name for the action #83912

alexdima opened this issue Nov 4, 2019 · 3 comments
Assignees
@sbatten
Labels
candidate Issue identified as probable candidate for fixing in the next release polish Cleanup and polish issue verified Verification succeeded
Milestone
October 2019

Comments

@alexdima
Copy link
Member

alexdima commented Nov 4, 2019 •
edited
Loading

IMHO using the keyboard modifier name in the action is not good, as IMHO the action name should describe what the action does, not one way in which the action is triggered.

This gets very confusing when configuring "editor.multiCursorModifier": "ctrlCmd". In this case, the definition preview is rendered in the editor hover with alt + hover.

Perhaps a better name would be "Show Definition Preview Hover".
@sbatten sbatten closed this as completed in 39130e5 Nov 4, 2019
sbatten added a commit that referenced this issue Nov 4, 2019
@sbatten
fixes #83912
1e1a5c6
@sbatten sbatten mentioned this issue Nov 4, 2019
Merged
@sbatten sbatten added candidate Issue identified as probable candidate for fixing in the next release polish Cleanup and polish issue labels Nov 4, 2019
@sbatten sbatten added this to the October 2019 milestone Nov 4, 2019
sbatten added a commit that referenced this issue Nov 4, 2019
@sbatten
Rename Show Control Hover (better naming) (#83937)
0788e5b 
* fixes #83912

* remove any mention of mod+hover
@alexdima alexdima added the verified Verification succeeded label Nov 5, 2019
@alexdima
Copy link
Member Author

alexdima commented Nov 5, 2019

Thank you!

@gjsjohnmurray
Copy link
Contributor

Release notes still use the old terminology:
image

Version: 1.40.0-insider (user setup)
Commit: 86405ea
Date: 2019-11-06T16:58:49.777Z
Electron: 6.1.2
Chrome: 76.0.3809.146
Node.js: 12.4.0
V8: 7.6.303.31-electron.0
OS: Windows_NT x64 10.0.17134

@sbatten
Copy link
Member

sbatten commented Nov 7, 2019

@gjsjohnmurray stable release notes should have the updates, thanks for checking it out

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sbatten sbatten

Labels
candidate Issue identified as probable candidate for fixing in the next release polish Cleanup and polish issue verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@alexdima @sbatten @gjsjohnmurray