Fixes #7366 Remove leaked breakpoint after stopping with run-to-cursor

[edumunoz]

Add a listener for the exit event as well to remove the generated breakpoint in RunToCursorAction.

@isidorn @weinand

[mention-bot]

By analyzing the blame information on this pull request, we identified @isidorn and @egamma to be potential reviewers

[weinand]

@edumunoz clearing the temporary breakpoints at the end of the session seems to be rather late. Shouldn't they be cleared on the next StoppedEvent?
If they are not shown in the UI (as you suggested), a user might lose track of them until the end of the section.

[edumunoz]

clearing the temporary breakpoints at the end of the session seems to be rather late. Shouldn't they be cleared on the next StoppedEvent

That's already being done (onDidStop). However, that event is not being triggered if the debug session ends without stopping first. That's what this PR fixes.

If they are not shown in the UI (as you suggested), a user might lose track of them until the end of the section.

I consider these breakpoints an implementation detail. The user never set any breakpoints for this to work, so why show any?

[weinand]

I'm in violent agreement that the 'run-to-cursor' breakpoints shouldn't be shown.

I had mis-interpreted the original problem: I thought the bug was that a 'run-to-cursor' breakpoint was not cleared immediately on the next stop if it was not hit. And your PR would clear those breakpoints only at the very end of the session (instead of at the next StoppedEvent). In that case a user might lose track of them if they not shown.

[isidorn]

@edumunoz thanks for the PR! Sorry for the slow response I was on vacation.
Looks good overall, however I would not expose onDidExitAdapter in rawDebugSessionas we already have onDidEvent. So in the action on you could listen on all events and if event.event = stopped or event.event = terminated or event.event = exit remove the brekapoint.

[isidorn]

Great work 🍻