Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run to cursor to a previously executed line results in a leaked breakpoint #7366

Closed
edumunoz opened this issue Jun 7, 2016 · 3 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@edumunoz
Copy link
Contributor

edumunoz commented Jun 7, 2016

  • VSCode Version: 1.2.0
  • OS Version: OS X

I understand this is a result of the implementation of RunToCursorAction, which basically creates a breakpoint at the specified location, continues the execution, and remove the breakpoint once it has been hit.

Steps to Reproduce:

  1. Set a breakpoint and start debugging.
  2. Select Run to cursor in the context menu for a line that won't be executed
  3. Stop the program

Result: there is a leaked breakpoint where run to cursor was called.

runtocursorbug

@isidorn @weinand

@edumunoz
Copy link
Contributor Author

edumunoz commented Jun 7, 2016

I opened PR #7367.

The best experience would also hide these breakpoints from the UI.

@weinand
Copy link
Contributor

weinand commented Jun 8, 2016

@isidorn we should clear all temporary breakpoints after the program has stopped again (step 3 from above)

@weinand weinand removed their assignment Jun 8, 2016
@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jun 8, 2016
@weinand weinand added this to the June 2016 milestone Jun 8, 2016
isidorn added a commit that referenced this issue Jun 15, 2016
Fixes #7366 Remove leaked breakpoint after stopping with run-to-cursor
@isidorn isidorn assigned weinand and unassigned isidorn Jun 15, 2016
@weinand
Copy link
Contributor

weinand commented Jul 4, 2016

while verifying this I found #8731

@weinand weinand added the verified Verification succeeded label Jul 4, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants