-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use active theme colors for styled text in the debug console #71458
Conversation
@iansan5653 ok, let me know when you ran all the tests and they are good. |
@isidorn I've gotten everything working, except the tests are failing for apparently no reason. I think it's because the
Is this the correct way to do it for tests? |
@iansan5653 that's the proper way to create a |
Yeah, I've been trying to fix those for a while now. I know the class is being applied because when I compile and run it, I can see the class in the developer tools. I just don't know why the assertion is failing. I'll keep trying to resolve. |
@iansan5653 If you do not figure it out, I can look in two weeks when I should have more time. |
Thanks a lot. However we are currently in endgame before the release which means we only accept a limited set of changes. Due to that assigning this to May when I plan to merge it (in about 10 days) |
Thanks a lot for this PR. And sorry for merging with a bit of a delay. |
No problem! Thanks for the advice and the merge. |
Draft because I'm not able to run tests / compile on this machine at the moment, but the code is pretty much done and ready for input.A problem with this approach is that after text is logged, if the user changes the theme, the logged text won't change color. One thing I considered was keeping the CSS rules but with CSS variables and dynamically changing the variables, but that seemed like it was introducing a lot of unnecessary complexity for an issue that isn't even much of an issue at all (the debug console is cleared often anyway).
Will fix #63986 and fix #42388.