Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support high intensity ansi colours in debug console #63986

Closed
MontyBlenheim opened this issue Nov 29, 2018 · 3 comments · Fixed by #71458
Closed

Support high intensity ansi colours in debug console #63986

MontyBlenheim opened this issue Nov 29, 2018 · 3 comments · Fixed by #71458
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@MontyBlenheim
Copy link

This issue is basically to revive one I previously found: #21423

The issue was closed when underlining functionality was added, but the original request, for high intensity colours, was never addressed. Any chance these could be added?

I was using the c++ extension and my program would log using the ANSI codes. I saw no visible difference in colour between, for example:

Red (\033[31m)
Bright Red (\033[31;1m)
aixterm Bright Red (\033[91m)

Colour code output

Now clearly you've gone for the "bold" interpretation of the "bold or high intensity" option of having ";1" after your colour. But is there any chance of the aixterm versions working?

@weinand weinand assigned isidorn and unassigned weinand Nov 29, 2018
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues debug-console labels Nov 29, 2018
@isidorn isidorn added the feature-request Request for new features or functionality label Nov 29, 2018
@isidorn isidorn added this to the Backlog milestone Nov 29, 2018
@isidorn isidorn removed their assignment Nov 29, 2018
@iansan5653
Copy link
Contributor

Relevant code is https://github.com/Microsoft/vscode/blob/1f64c126721a66f30a7dcc3ac9e605e8115bcca7/src/vs/workbench/contrib/debug/browser/media/repl.css#L130.

I'll submit a pull request for this tomorrow if there's no objections.

@alexr00
Copy link
Member

alexr00 commented May 29, 2019

I think that they look different, but it's subtle.

	console.log('\033[31mRed\x1b[0m');
	console.log('\033[31;1mBright Red\x1b[0m');
	console.log('\033[91maixterm Bright Red\x1b[0m');

image

@alexr00 alexr00 added the verified Verification succeeded label May 29, 2019
@iansan5653
Copy link
Contributor

The exact colors depend on the theme so it can be pretty subtle but it's there.
image

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
5 participants