Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align badge theming with the GUI badge #61965

Merged
merged 2 commits into from
Oct 29, 2018
Merged

Align badge theming with the GUI badge #61965

merged 2 commits into from
Oct 29, 2018

Conversation

usernamehw
Copy link
Contributor

Fixes #61959

@usernamehw
Copy link
Contributor Author

Not sure if no-results class should be deleted from the element.

@roblourens
Copy link
Member

Looks great but yeah the no-results class can be removed, please do that too

roblourens
roblourens approved these changes Oct 29, 2018
View reviewed changes
Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roblourens roblourens merged commit 4626bc0 into microsoft:master Oct 29, 2018
@usernamehw usernamehw deleted the align-badge-color branch October 29, 2018 09:56
@roblourens roblourens added this to the October 2018 milestone Nov 2, 2018
@usernamehw
Copy link
Contributor Author

@roblourens, there is now an unused parameter count (I didn't see it)

https://github.com/Microsoft/vscode/blob/0817eb5df51f810d5a543f93a71e16c713a62570/src/vs/workbench/parts/preferences/browser/preferencesWidgets.ts#L649-L651

@roblourens
Copy link
Member

Thanks, I just cleaned it up

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@roblourens roblourens roblourens approved these changes

Assignees

@roblourens roblourens

Labels
None yet
Projects
None yet
Milestone
October 2018
Development

Successfully merging this pull request may close these issues.

Use standard badge color for No Results label in settings
2 participants
@usernamehw @roblourens