Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard badge color for No Results label in settings #61959

Closed
usernamehw opened this issue Oct 27, 2018 · 1 comment · Fixed by #61965
Closed

Use standard badge color for No Results label in settings #61959

usernamehw opened this issue Oct 27, 2018 · 1 comment · Fixed by #61965
Assignees

Comments

@usernamehw
Copy link
Contributor

usernamehw commented Oct 27, 2018

In approx 1/4 of my installed themes this badge looks awful:

screenshot 94

Having no-results just doesn't feel like an error. Standard badge color (Like white here on github badge) is fine(because it's usually made for it).

P.S. no need for a new color, already too many of them.

P.P.S. actually new settings editor doing exactly that:
screenshot 95

So, it just needs to be aligned with the GUI version of settings.

@vscodebot
Copy link

vscodebot bot commented Oct 27, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants