Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make titlebar more consistent with Windows 10 #53211

Merged
merged 2 commits into from
Jul 2, 2018

Conversation

yzhang-gh
Copy link
Contributor

Window Controls Width

Edge
edge

VSCode Before
vscode before

VSCode After
vscode after

Transition Duration

0.2s -> 0.1s

@bpasero
Copy link
Member

bpasero commented Jun 28, 2018

@neilsustc what is the purpose of the transition for the window buttons?

@yzhang-gh
Copy link
Contributor Author

The same reason, being more consistent with native effects.

It is hard to be recorded with GIFs but you can feel the transition duration is more like 0.1s rather than 0.2s.

@bpasero
Copy link
Member

bpasero commented Jun 28, 2018

@neilsustc I was more wondering what the transition does, e.g. when and where does it apply?

@yzhang-gh
Copy link
Contributor Author

yzhang-gh commented Jun 28, 2018

transition

VSCode needs more time to react. (I should have compared them using the light theme to be fair... but you know what I mean)


They only apply to the window controls - ◻ x of titlebar when you move cursor on/off.

@bpasero
Copy link
Member

bpasero commented Jun 28, 2018

Interesting, thanks for the info.

@bpasero bpasero mentioned this pull request Jun 28, 2018
11 tasks
@yzhang-gh
Copy link
Contributor Author

I find another thing, the margin of "hr"

image

Although it seems to be a small detail, it is very noticeable to me...

Can I fix it in this PR? It is not about titlebar any more, but it is quite simple (one margin) so maybe there is no need for another PR.

@yzhang-gh
Copy link
Contributor Author

image

I guess I'd better to create a separate issue for custom menus.

@miguelsolorio
Copy link
Contributor

@neilsustc I’d suggest making a different PR for fixing the menu spacing/alignment

@yzhang-gh
Copy link
Contributor Author

👌

@sbatten sbatten merged commit a115c73 into microsoft:master Jul 2, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants