Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Title: Icons differ from standard windows icons #53015

Closed
Tyriar opened this issue Jun 26, 2018 · 5 comments
Closed

Custom Title: Icons differ from standard windows icons #53015

Tyriar opened this issue Jun 26, 2018 · 5 comments
Assignees
Labels
debt Code quality issues titlebar VS Code main title bar issues
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2018

#52854

  • Minimize line is thicker
  • Maximize box is smaller
  • Close button is smaller
  • Restore is smaller and blurry

Top: Notepad
Bottom: VS Code

image

Notepad:

image

VS Code:

image

@Tyriar Tyriar added the titlebar VS Code main title bar issues label Jun 26, 2018
@miguelsolorio
Copy link
Contributor

@sbatten is there any way to use the native icons? I'm trying to look for the originals in case we need to specify the svgs.

@sbatten
Copy link
Member

sbatten commented Jun 28, 2018

@misolori not sure how they are drawn by the OS, but I think the icons are part of the Segoe MDL2 Assets font in Windows 10.

@Tyriar
Copy link
Member Author

Tyriar commented Jun 28, 2018

I think an SVG will always have the possibility of being blurry won't it, because SVGs don't have the features that fonts do to align to the pixel grid?

@yzhang-gh
Copy link
Contributor

FYI, I think this will be fixed with #53211.

@bpasero bpasero changed the title Menu: Icons differ from standard windows icons Custom Title: Icons differ from standard windows icons Jul 2, 2018
@sbatten sbatten added the debt Code quality issues label Jul 3, 2018
@sbatten
Copy link
Member

sbatten commented Aug 8, 2018

seems resolved. please verify @Tyriar

@sbatten sbatten closed this as completed Aug 8, 2018
@sbatten sbatten added this to the August 2018 milestone Aug 8, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues titlebar VS Code main title bar issues
Projects
None yet
Development

No branches or pull requests

4 participants