Deprecating old emmet #31783
Merged
Deprecating old emmet #31783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ramya-rao-a, thanks for your PR! By analyzing the history of the files in this pull request, we identified @egamma and @alexandrudima to be potential reviewers. |
|
I miss it. It was kind of nice to see the evolving. But it's time to say goodbye. 😭 |
|
@jens1o I thought you were pretty happy with the new model ? :) |
|
Well, I am(thanks to you!), but I like old things too, because they have some other ways of providing a solution, even though their way was worse, but they are interesting in the way they had solved these problems. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we deprecate old emmet.
All Emmet actions have been moved to the Emmet extension.
Expand AbbreviationandWrap with Abbreviationstill go through the core so that languages whose parent are html as well as embedded languages get these 2 commands working out of the box. Eg: handlebars, php or vueOnce scope information is available to extensions, this can be skipped.