-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi root: Use new emmet to avoid single workspace dependency #29244
Comments
We wouldnt need that once we move completely to new emmet which should be by 1.15 |
@ramya-rao-a that is awesome to hear, yeah l will rename the title then |
Moving this to August. Though we are turning the new emmet on for 1.5, we are retaining the option to use old emmet as there are few upstream issues still not fixed. |
With #31783, you force to use the new emmet, don't you @ramya-rao-a? https://github.com/Microsoft/vscode/pull/31783/files#diff-9ee74d46e46b70e6a90f571978e9df07R258 |
Yes, the PR is was prep work for when we do decide to deprecate emmet. Which I thought we had to move to August as there were a few other issues for which I needed upstream fixes. But they got approved in the last hour :) So I am planning to go ahead with this now. |
It looks like we are looking for emmet specific configuration files inside the workspace: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/emmet/electron-browser/emmetActions.ts#L289
This will not work anymore once we are in a multi root environment. I am not sure what the configuration is for but you probably need to read it per workspace root and then support it based on from which file the emmet action is executed.
The text was updated successfully, but these errors were encountered: