Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi root: Use new emmet to avoid single workspace dependency #29244

Closed
bpasero opened this issue Jun 22, 2017 · 5 comments
Closed

Multi root: Use new emmet to avoid single workspace dependency #29244

bpasero opened this issue Jun 22, 2017 · 5 comments
Assignees
Labels
debt Code quality issues emmet Emmet related issues workbench-multiroot Multi-root (multiple folders) issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jun 22, 2017

It looks like we are looking for emmet specific configuration files inside the workspace: https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/emmet/electron-browser/emmetActions.ts#L289

This will not work anymore once we are in a multi root environment. I am not sure what the configuration is for but you probably need to read it per workspace root and then support it based on from which file the emmet action is executed.

@bpasero bpasero added emmet Emmet related issues workbench-multiroot Multi-root (multiple folders) issues labels Jun 22, 2017
@ramya-rao-a
Copy link
Contributor

We wouldnt need that once we move completely to new emmet which should be by 1.15
Do you still want to keep this issue to track it?

@bpasero bpasero changed the title Emmet configuration is not multi-root fit Multi root: Use new emmet to avoid single workspace dependency Jun 26, 2017
@bpasero bpasero added this to the July 2017 milestone Jun 26, 2017
@bpasero
Copy link
Member Author

bpasero commented Jun 26, 2017

@ramya-rao-a that is awesome to hear, yeah l will rename the title then

@ramya-rao-a
Copy link
Contributor

Moving this to August.

Though we are turning the new emmet on for 1.5, we are retaining the option to use old emmet as there are few upstream issues still not fixed.

@ramya-rao-a ramya-rao-a modified the milestones: August 2017, July 2017 Jul 31, 2017
@jens1o
Copy link
Contributor

jens1o commented Jul 31, 2017

Though we are turning the new emmet on for 1.5, we are retaining the option to use old emmet as there are few upstream issues still not fixed.

With #31783, you force to use the new emmet, don't you @ramya-rao-a? https://github.com/Microsoft/vscode/pull/31783/files#diff-9ee74d46e46b70e6a90f571978e9df07R258

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Jul 31, 2017

Yes, the PR is was prep work for when we do decide to deprecate emmet.

Which I thought we had to move to August as there were a few other issues for which I needed upstream fixes.
See emmetio/abbreviation#2 and emmetio/abbreviation#3

But they got approved in the last hour :)

So I am planning to go ahead with this now.

@ramya-rao-a ramya-rao-a modified the milestones: July 2017, August 2017 Jul 31, 2017
@ramya-rao-a ramya-rao-a added the debt Code quality issues label Jul 31, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debt Code quality issues emmet Emmet related issues workbench-multiroot Multi-root (multiple folders) issues
Projects
None yet
Development

No branches or pull requests

3 participants