Terminal: Add Find next/previous key bindings. Fixes: #29661 #31418
+73
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebornix
reviewed
Jul 25, 2017
| @@ -322,6 +324,14 @@ actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(HideTerminalFind | |||
| primary: KeyCode.Escape, | |||
| secondary: [KeyCode.Shift | KeyCode.Escape] | |||
| }, ContextKeyExpr.and(KEYBINDING_CONTEXT_TERMINAL_FOCUS, KEYBINDING_CONTEXT_TERMINAL_FIND_WIDGET_VISIBLE)), 'Terminal: Focus Find Widget', category); | |||
| actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(NextMatchTerminalFindWidgetAction, NextMatchTerminalFindWidgetAction.ID, NextMatchTerminalFindWidgetAction.LABEL, { | |||
| primary: KeyCode.F3 | |||
| }, KEYBINDING_CONTEXT_TERMINAL_FOCUS), 'Terminal: Find Next', category); | |||
There was a problem hiding this comment.
Usually for macOS, we use another keybinding -> https://github.com/Microsoft/vscode/blob/master/src/vs/editor/contrib/find/common/findController.ts#L372
There was a problem hiding this comment.
@rebornix
I looked at the OS X key bindings and Find Next appears to be F3 ^F3 for previous
is this not correct?
There was a problem hiding this comment.
Funny thing is that that's what I had first ;-)
will change back
There was a problem hiding this comment.
Our builtin primary one is cmd+g but cmd+F3 works as well. Yeah let's make it consistent.
rebornix
reviewed
Jul 25, 2017
| }, KEYBINDING_CONTEXT_TERMINAL_FOCUS), 'Terminal: Find Next', category); | ||
| actionRegistry.registerWorkbenchAction(new SyncActionDescriptor(PreviousMatchTerminalFindWidgetAction, PreviousMatchTerminalFindWidgetAction.ID, PreviousMatchTerminalFindWidgetAction.LABEL, { | ||
| primary: KeyMod.Shift | KeyCode.F3 | ||
| }, KEYBINDING_CONTEXT_TERMINAL_FOCUS), 'Terminal: Find Previous', category); |
|
Just left a tiny comment about keybindings, it looks good to me. |
|
OS X Key bindings matched. |
Closed
|
See new PR #32074 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Tyriar
Fixes: #29661