Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No next and previous keyboard shortcuts for Find widget in Integrated Terminal #29661

Closed
gregvanl opened this issue Jun 27, 2017 · 7 comments · Fixed by #58850
Closed

No next and previous keyboard shortcuts for Find widget in Integrated Terminal #29661

gregvanl opened this issue Jun 27, 2017 · 7 comments · Fixed by #58850
Assignees
@alexr00
Labels
feature-request Request for new features or functionality on-testplan terminal General terminal issues that don't fall under another label verified Verification succeeded
Milestone
September 2018

Comments

@gregvanl
Copy link

  • VSCode Version: 1.14 Insiders
  • OS Version: Windows 7

Steps to Reproduce:

  1. Open Find widget and search for a string with several matches

There are no keyboard shortcuts for previous and next match (Shift + F3, F3).
@vscodebot vscodebot bot added the insiders label Jun 27, 2017
@vscodebot vscodebot bot added the terminal General terminal issues that don't fall under another label label Jun 27, 2017
@Tyriar Tyriar added feature-request Request for new features or functionality and removed insiders labels Jun 27, 2017
@Tyriar Tyriar added this to the Backlog milestone Jun 27, 2017
@gregvanl
Copy link
Author

Found during #29479

@fabiospampinato
Copy link
Contributor

I agree that those actions should have the same shortcuts used in the editor's search widget bound to them, by default.

@Tyriar Tyriar added the help wanted Issues identified as good community contribution opportunities label Jul 13, 2017
@cleidigh
Copy link
Contributor

@Tyriar
I will add these key bindings

@cleidigh cleidigh mentioned this issue Jul 25, 2017
Closed
@cleidigh
Copy link
Contributor

Addressed by PR #31418

This was referenced Aug 7, 2017
Closed
Merged
@cleidigh cleidigh mentioned this issue Sep 8, 2017
Closed
3 tasks
@Tyriar Tyriar closed this as completed Dec 23, 2017
@Tyriar
Copy link
Member

Tyriar commented Dec 27, 2017

Reopening, #32113 didn't resolve

@Tyriar Tyriar reopened this Dec 27, 2017
@cleidigh
Copy link
Contributor

cleidigh commented Dec 28, 2017 •
edited
Loading

@Tyriar
I have these functions from the summer work that was not merged. I can update and post a PR.
Reminder : We also needed to add these to extension and mardown editors. I have this also.

Give me a thumbs up if this sounds good.

@Tyriar
Copy link
Member

Tyriar commented Dec 31, 2017

I think ideally F3/shift+F3 would work the same everywhere 👍

@cleidigh cleidigh mentioned this issue Feb 22, 2018
Closed
@alexr00 alexr00 assigned alexr00 and unassigned Tyriar Sep 12, 2018
This was referenced Sep 14, 2018
Merged
Merged
@alexr00 alexr00 removed the help wanted Issues identified as good community contribution opportunities label Sep 18, 2018
alexr00 added a commit that referenced this issue Sep 19, 2018
@alexr00
Add keybindings to terminal find next and previous (#58850)
3d1bec9 
Added keybindings for terminal find next and find previous and updated regex, whole word, and case sensitive keybindings to match the way next and previous work. Fixes #29661
@Tyriar Tyriar modified the milestones: Backlog, September 2018 Sep 19, 2018
@gregvanl gregvanl added the verified Verification succeeded label Sep 20, 2018
@alexr00 alexr00 mentioned this issue Sep 24, 2018
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexr00 alexr00

Labels
feature-request Request for new features or functionality on-testplan terminal General terminal issues that don't fall under another label verified Verification succeeded
Projects
None yet
Milestone
September 2018
5 participants
@fabiospampinato @Tyriar @gregvanl @cleidigh @alexr00