Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve Git Bash integration on Windows (#151105) #165428

Merged
merged 2 commits into from
Nov 9, 2022
Merged

improve Git Bash integration on Windows (#151105) #165428

merged 2 commits into from
Nov 9, 2022

Conversation

Okeanos
Copy link
Contributor

@Okeanos Okeanos commented Nov 3, 2022

Bash sessions should be started as interactive (-i) sessions to enable history commands by default.
This is the same setup used by the official Git for Windows JSON fragment extension for Windows Terminal.

This does not fix the issue at this time, however, because bash signal handling on Windows for quit/close/kill signals does not work as expected.

Bash sessions should be started as interactive (`-i`) sessions to enable history
commands by default.
This is the same setup used by the official Git for Windows JSON fragment
extension for Windows Terminal.

This does not fix the issue at this time, however, because bash signal handling
on Windows for quit/close/kill signals does not work as expected.
@Tyriar Tyriar added this to the November 2022 milestone Nov 9, 2022
@Tyriar Tyriar requested a review from meganrogge November 9, 2022 23:00
@meganrogge meganrogge enabled auto-merge (squash) November 9, 2022 23:35
@meganrogge meganrogge merged commit 245c0c7 into microsoft:main Nov 9, 2022
@Okeanos Okeanos deleted the improve-git-bash-integration branch November 10, 2022 06:40
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants