Skip to content

Commit

Permalink
improve Git Bash integration on Windows (#151105) (#165428)
Browse files Browse the repository at this point in the history
Bash sessions should be started as interactive (`-i`) sessions to enable history
commands by default.
This is the same setup used by the official Git for Windows JSON fragment
extension for Windows Terminal.

This does not fix the issue at this time, however, because bash signal handling
on Windows for quit/close/kill signals does not work as expected.
  • Loading branch information
Okeanos authored Nov 9, 2022
1 parent b9b93f2 commit 245c0c7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/vs/platform/terminal/node/terminalProfiles.ts
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ async function initializeWindowsProfiles(testPwshSourcePaths?: string[]): Promis
`${process.env['LocalAppData']}\\Programs\\Git\\bin\\bash.exe`,
`${process.env['UserProfile']}\\scoop\\apps\\git-with-openssh\\current\\bin\\bash.exe`,
],
args: ['--login']
args: ['--login', '-i']
});
profileSources.set('PowerShell', {
profileName: 'PowerShell',
Expand Down

0 comments on commit 245c0c7

Please sign in to comment.