chore: update to electron 12

[deepak1556]

• Build nightly exploration builds

Fixes #112319

[darkbasic]

That would fix all the issues with Wayland * . *

[johnsoncodehk]

May fix a node 12 issue: https://bugs.chromium.org/p/chromium/issues/detail?id=1180495

[Saverio-Angelicola]

Hello, are you thinking of finishing the migration from vscode to electron 12 in order to natively support wayland to integrate it in the April update or will it take longer?

[deepak1556]

There are two parts to the vscode-sqlite3 shutdown crash

1. Exception thrown by the sqlite3 module should not be propagated from the napi module if the environment is torn down, there is ongoing discussion src: fix a crashing issue in Error::ThrowAsJavaScriptException nodejs/node-addon-api#902

2. It is unknown whether closing database during shutdown is a valid operation, currently the cause of the crash Crash if db.close() is called in process.on('exit') TryGhost/node-sqlite3#1455

As workaround can we move the close operation to an early stage before process shutdown kicks in ?

[bpasero]

As workaround can we move the close operation to an early stage before process shutdown kicks in ?

We prolong the shutdown for as long the database needs to close already, otherwise we would see dataloss, no? I am not sure what else I can do here, I think there is an issue with the library maybe that returns before the DB has been closed? Can we file this against the library?

[deepak1556]

TryGhost/node-sqlite3#1455 covers it, I need to add some logs to our fork to understand where the failure is as next step.

[pixieaka]

@deepak1556 How I can download vscode exploration builds?

[deepak1556]

There is no public page adding download links below,

Window x64 user setup
Linux x64 deb
Linux x64 rpm
Linux x64 snap
MacOS universal

[bpasero]

Besides my feedback, I notice that we still use node.js 12 here:

build/azure-pipelines/darwin/product-build-darwin-sign.yml

[bpasero]

Please undo if merged to main

[ninja-]

@deepak1556 thanks for these builds, I will try to use it as a daily and find any problems :)

Chrome dev builds are still too buggy at the moment for using wayland daily, but hopefully some of these bugs may not trigger while using vscode.

btw. I wouldn't recommend starting testing with a snap/flatpak builds because there have been issues with it like breaking hardware acceleration etc.

but even in deb build, I can't force this exploration build to use opengl?

code-exploration --ozone-platform=wayland --enable-features=UseOzonePlatform --ignore-gpu-blacklist --enable-gpu-rasterization --enable-native-gpu-memory-buffers --status
Warning: 'ozone-platform' is not in the list of known options, but still passed to Electron/Chromium.
Warning: 'enable-features' is not in the list of known options, but still passed to Electron/Chromium.
Warning: 'ignore-gpu-blacklist' is not in the list of known options, but still passed to Electron/Chromium.
Warning: 'enable-gpu-rasterization' is not in the list of known options, but still passed to Electron/Chromium.
Warning: 'enable-native-gpu-memory-buffers' is not in the list of known options, but still passed to Electron/Chromium.
[1170095:0412/230106.987817:ERROR:viz_main_impl.cc(150)] Exiting GPU process due to errors during initialization
[1170200:0412/230107.038234:ERROR:sandbox_linux.cc(374)] InitializeSandbox() called with multiple threads in process gpu-process.
Version:          Code - Exploration 1.56.0-exploration (dbd55768bc820fcf8ad2076b4befb6bfacf14f72, 2021-04-07T05:46:50.135Z)
OS Version:       Linux x64 5.11.11-051111-generic
CPUs:             AMD Ryzen 9 3900X 12-Core Processor (24 x 3800)
Memory (System):  31.30GB (5.57GB free)
Load (avg):       1, 1, 1
VM:               0%
Screen Reader:    no
Process Argv:     --ozone-platform=wayland --enable-features=UseOzonePlatform --ignore-gpu-blacklist --enable-gpu-rasterization --enable-native-gpu-memory-buffers --no-sandbox
GPU Status:       2d_canvas:                  unavailable_software
                  gpu_compositing:            disabled_software
                  multiple_raster_threads:    enabled_on
                  oop_rasterization:          disabled_off
                  opengl:                     disabled_off
                  rasterization:              disabled_software
                  skia_renderer:              enabled_on
                  video_decode:               disabled_software
                  vulkan:                     disabled_off
                  webgl:                      unavailable_software
                  webgl2:                     unavailable_software

[ninja-]

ok I finally found the issue with opengl! it's because google changed argument name from GPU BLACKLIST to GPU BLOCKLIST...

[deepak1556]

Stable 1.56 will be based on electron 12