-
Notifications
You must be signed in to change notification settings - Fork 29.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gnome fractional scaling not supported - blurry UI #72759
Comments
Sadly I am on fedora linux and use the |
This issue effects anything that's based on chromium including current Google Chrome. @LennyPenny are you using Wayland on Fedora 30 by any chance? I'm guessing you are as I believe Gnome 3.32 fractional scaling is only available on Wayland. Anything that has to use XWayland (which I think includes current Chromium) ends up blurry as it's not using optimal scaling compared to toolkits like Gtk and Qt that have native Wayland support. There is some work on chromium Wayland support, much of it here https://github.com/Igalia/chromium with some already upstream. Until there is proper fractional scaling support It may be possible to force UI scaling off in chromium and instead use font scaling that would at least not be blurry. Widgets however won't be scaled. |
This Chromium issue needs more visibility, I hope this vscode issue will help to fix it faster. Chromium Wayland support development is being tracked here: https://bugs.chromium.org/p/chromium/issues/detail?id=578890 I wasn't able to pinpoint what exactly should be fixed in Chromium's behavior on Xwayland, or, perhaps, in Xwayland itself. I hope something may be done with one or the other to mitigate this while proper Wayland support is underway. EDIT: An Xwayland ticket with some discussion here: https://bugzilla.freedesktop.org/show_bug.cgi?id=93315 |
@carwyn yes, gnome fractional scaling is wayland only, which I am using |
@bpasero there's no change; see the link @khvn26 already posted above for the upstream Chromium effort: https://bugs.chromium.org/p/chromium/issues/detail?id=578890 |
This is the same underlying issue as #41345 |
Note that this is not Gnome-specific. It affect any modern Linux system running on Wayland (instead of Xorg). |
Any update on this ? The lack of fractionnal support from vscode under wayland seems like a pretty big deal... |
Electron has recently added wayland support and it will probably be shipped with Electron 12 (which should happen in a few weeks if you go by their schedule). As is stated in #109176, VSCode will consume the new binaries when released and this issue will finally go away. |
I can’t wait for this annoying issue to finally go away. 4K displays are not a rarity anymore theses days. Especially with Developers and IT engineers. I have switched from Chrome back to Firefox because of this. Wayland is working stable with Fedora+GNOME+fractional-scaling already. The upcoming Fedora 34 will switch also KDE/Plasma’s default to Wayland. This issue is pretty much the last problem keeping me from fully adopting a Linux workstation. |
@paidhi Chrome's 87.x builds' Wayland support is quite telling. Loving it on my XPS 15! Hope Electron's roll out v12 soon. |
Electron 12 was recently released. |
Hello, is there a version of vscode that is available with electron 12 support for native wayland support to download. |
Not yet (at least not officially), but almost there. It seems like I vastly overestimated how soon electron 12 would release. You can check the ongoing PR at #120034. |
1.56 is on electron 12 but still it looks blurry on wayland fractional scaling. |
You need to pass the CLI args: #109176 (comment) |
Are you sure that's what the issue is about? I reread the OP and it doesn't mention that this is specific to Wayland. I think there might be several different issues being mixed up here. |
@cbrnr from the first few comments:
|
Yes, and switching from XWayland to native Wayland solved the issue for me. |
yes and the point is this issue isn't about xwayland, and we're just blowing up the thread with OT comments. |
@edrex I read the whole thread again, and to me it seems like you (and some others) are having a different problem (crisp menu text, blurry UI). This is not what the OP reported, and many others (including me) could solve their blurry VS Code with the CLI flags (although this is still not working by default, which it should, and I couldn't get the app icon to show up, and GPU drivers seem to play a role as well). Maybe it would be a good idea to create a new issue on what you're seeing? If you want, I can also open a new issue on providing a setting to switch to Wayland, fix the icon, and maybe do that by default on Wayland. But again, I believe that the original issue is more or less fixed, and you are reporting a new (different) one. |
@cbrnr rereading the thread carefully, I see you are right. The original report is from well before Wayland suppport landed in Electron, and instead it's about when running under xwayland. The issue I'm seeing seems to be that windows aren't updated with the current output scale: dis+enabling the hidpi display with blurry vscode windows crisps them up. I'm not ready to file but someone can feel free to, or link an upstream issue here. |
To summarize the fix and remaining issues (VS Code devs might want to follow up, @deepak1556 maybe?):
|
Yes, #135191 should fix most problems. Like I said, I think it would be nice if Wayland was enabled by default if running on Wayland. The only remaining issue I see is the missing app icon, but maybe this is just an artifact of the flags that are not properly integrated now. Is anything still missing in this PR? |
Just got back from vacation, I updated all my packages (fedora 36), vscode to 1.70.1 and this solution stopped working with my monitor setup. I have two monitors, my main 4K display (150% scale) and a 1080p secondary (100% scale). The only way I could solve this is by setting my 1080p scale to 125%. |
I found a work around,
|
Edit. 20221110 I'm able to use it with Ubuntu 22.10 but with some changes: Now the icon is not visibile, I had to change also StartupVMClass: does not work with ubuntu 22.04 |
i am using fedora 36, try launching vscode from terminal, using |
There's a strange bug which does not happen with other electron apps. When I use a second screen and it is positioned above the primary screen, even if I use the Wayland flag, text is blurry until I reload the window or disable then enable 2nd screen. Flag work fine if 2nd screen is in default position. |
@cbrnr thanks for summarizing the issue thread in #72759 (comment). Wayland support is available in the runtime and as mentioned in this issue thread multiple time, it can be enabled either with
We cannot add Also, known wayland issues in VSCode are tracked in this repo. If there is a issue missing for something you encountered with latest version of VSCode, please file one with repro steps. Thanks for understanding. |
The duplicate app icon and the missing drop shadow issues should also be fixed before Wayland becomes the default. Are these issues already tracked or should I open new issues? Chrome at least has a setting to enable Wayland (as opposed to a command line flag), and it doesn't have the duplicate icon issue. Maybe something to consider? |
Arch Linux has a setting to enable Wayland on Electron apps as well, it's just a matter of how you package Electron. |
I'm working under Ubuntu 22.04.1 with Gnome 42.5 and VSCode 1.74.0.
nothing happens, i.e., no window appears, no errors displayed in the terminal. If I run just |
@pstorozenko are you sure you are running Wayland and not X.org? |
I still have to reload the window as in this previous comment:
|
I (somehow) solved the problem! For some reason I had to remove vscode installation from When I run
Of course I have glibc installed on my machine, but the The same solution helped with the |
same problem in fedora look: |
I'm getting this same issue, I'm on sway (wayland) but my two monitors are just side by side. Neither is primary because that's not a thing in wayland This is even with it running wayland native with these flags:
|
Steps to Reproduce:
Top is vs code file browser, bottom is nautilus launched directly from gnome
According to https://gitlab.gnome.org/GNOME/mutter/issues/566 and https://bugs.launchpad.net/ubuntu/+source/mutter/+bug/1825625 this is an issue with vs code not having support for fractional scaling.
Is this a problem I should forward to the electron repo or is vs code the right place?
The text was updated successfully, but these errors were encountered: