Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom editor is not tagged deleted if file is deleted #99270

Closed
sandy081 opened this issue Jun 3, 2020 · 1 comment
Closed

Custom editor is not tagged deleted if file is deleted #99270

sandy081 opened this issue Jun 3, 2020 · 1 comment
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
March 2021

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 3, 2020 •
edited
Loading

Testing #99003

image

Example:

image
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Jun 5, 2020
@mjbvz mjbvz added this to the Backlog milestone Jun 5, 2020
@mjbvz mjbvz added the custom-editors Custom editor API (webview based editors) label Jun 5, 2020
@mjbvz mjbvz mentioned this issue Jan 19, 2021
Closed
@mjbvz mjbvz modified the milestones: Backlog, March 2021 Feb 27, 2021
@mjbvz mjbvz closed this as completed in f3f4eeb Feb 27, 2021
@mjbvz
Copy link
Collaborator

mjbvz commented Feb 27, 2021

For testing:

  1. Run the custom editor sample
  2. Copy both the binary (.pawDraw) and text files (.cscratch) from exampleFiles into a new workspace
  3. Also create a backup of these two files so you can restore them easily
  4. For each file:
  5. Open the file and make an edit. Do not save and ensure that the file is marked dirty
  6. Now use the command line to delete the file
  7. Confirm that the editor is now labeled (deleted)
  8. Now restore the file
  9. Confirm that the editor is no longer labeled deleted

fynxiu pushed a commit to fynxiu/vscode that referenced this issue Mar 1, 2021
@mjbvz @fynxiu
Label custom editor as deleted if the backing file is deleted
5302666 
Fixes microsoft#99270

This should make it so a custom editor tab is tagged `(deleted)` if the backing file is deleted
@lramos15 lramos15 added the verified Verification succeeded label Mar 24, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
March 2021
Development

No branches or pull requests
4 participants
@lramos15 @sandy081 @mjbvz and others