Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Custom editor finalization #99003

Closed
3 tasks done
mjbvz opened this issue Jun 2, 2020 · 0 comments
Closed
3 tasks done

Test: Custom editor finalization #99003

mjbvz opened this issue Jun 2, 2020 · 0 comments

Comments

@mjbvz
Copy link
Collaborator

mjbvz commented Jun 2, 2020

Test for #77131

Complexity: 5

Create Issue


Summary
The custom editor API has been finalized this iteration. There have been no major changes to the API however we've fixed a number of bugs around custom editors, and we would also like to have another set of testers to take a look at this API.

Note: If you have previously tested custom editors, consider reassigning it to someone who does not have experience with the API

In this exploratory test plan item, I'd like you to try implementing a basic custom editor as if you were an extension developer (possibly try embedding an existing html+js library into a custom editor).

Links

Areas to focus on

  • API docs and intellisense (for both the TS api and contribution point)

    Do they make sense? Anything missing?

  • Editing and basic saving

    Make sure undo, redo, and revert work for CustomEditor and CustomTextEditor. Make sure the VS Code UI updates correctly and that all fields on CustomDocument are updated correctly. Are there anything that prevents you from implementing your custom editor or that would simplify things?

  • Hot exit and backup

    Make sure custom editors are properly restored when the window is reloaded

  • The Reopen with command the the workbench.editorAssociations setting

    If there are multiple custom editors for a single resource, make sure you can use workbench.editorAssociations to configure which one is used by default

  • Try finding cases where a custom editor behaves differently from our normal editors

    Especially around renaming/deleting files and dirty states

@mjbvz mjbvz added this to the May 2020 milestone Jun 2, 2020
@sandy081 sandy081 removed their assignment Jun 3, 2020
@alexr00 alexr00 removed their assignment Jun 3, 2020
@9at8 9at8 removed their assignment Jun 4, 2020
@bpasero bpasero closed this as completed Jun 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants