Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation of viewType contribution #99264

Closed
sandy081 opened this issue Jun 3, 2020 · 0 comments
Closed

Improve documentation of viewType contribution #99264

sandy081 opened this issue Jun 3, 2020 · 0 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
May 2020

Comments

@sandy081
Copy link
Member

sandy081 commented Jun 3, 2020

Testing #99003

image

It just says it is an unique identifier even though it is not an id. It also needs to explain how it is connected to activation and registering custom editor using API

Eg:

image
@mjbvz mjbvz added this to the May 2020 milestone Jun 3, 2020
@mjbvz mjbvz mentioned this issue Jun 4, 2020
Closed
@mjbvz mjbvz added custom-editors Custom editor API (webview based editors) bug Issue identified by VS Code Team member as probable bug labels Jun 4, 2020
@mjbvz mjbvz closed this as completed in b3c2ecd Jun 4, 2020
@sandy081 sandy081 added the verified Verification succeeded label Jun 5, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug custom-editors Custom editor API (webview based editors) insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
May 2020
Development

No branches or pull requests
3 participants
@sandy081 @mjbvz and others