Loaded scripts view does not get dynamically updated

[isidorn]

Refs: #57249

Have the following JS workspace https://github.com/Microsoft/vscode/files/2238799/loadedScripts.zip
Start debugging hello.js, do a step by step. I would expect the loaded scripts updates and shows new scripts as they get required. Instead the view is always the same

[weinand]

@isidorn I suspect that loadedScripts events are no longer arriving.

[weinand]

@isidorn the new sessions event are no longer arriving here:
https://github.com/Microsoft/vscode/blob/93e30cc319bb2184756819aefbd4f16a27e7a17c/src/vs/workbench/parts/debug/browser/loadedScriptsView.ts#L374

As a consequence I do not register for loadedScriptsEvents.

This issue was probably introduced by the listener refactoring and should be referenced by test item #56822.

[isidorn]

The issue here was that the loaded scripts view gets created only after a session is already alive so he was missing listeners on session which is already present.

[weinand]

Careful: if the order of events has changed that drastically after your refactoring, we are potentially breaking extensions that use the newSessionEvent. I don't like this fix.

[isidorn]

The order of events has not changed. The only thing that changed is internaly how people register to the loadedScriptsEvent, since it is now on the session, not on the service.
So the extensions will not be affected by this.

[alexdima]

@isidorn Do we have a build with this fix to test #57249 further ? I can also test from sources, just LMK.

[isidorn]

@alexandrudima sorry about that. We do have linux and os x builds, however integration tests are faililng for windows. I will re-trigger builds since I see you have to test windows - they should be out in 30 minutes. And yes you can also test from source afaik
I will not release those builds, so just download them manually.