Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chrome debug: no loaded scripts view #55462

Closed
isidorn opened this issue Jul 31, 2018 · 6 comments · May be fixed by maxemiliang/vscode-ext#27, stefanonepa/vscode-chrome-debug#4 or maxemiliang/vscode-ext#28
Closed

Chrome debug: no loaded scripts view #55462

isidorn opened this issue Jul 31, 2018 · 6 comments · May be fixed by maxemiliang/vscode-ext#27, stefanonepa/vscode-chrome-debug#4 or maxemiliang/vscode-ext#28
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
August 2018

Comments

@isidorn
Copy link
Contributor

isidorn commented Jul 31, 2018

Refs #54921

  1. Start debugging using the chrome extension
  2. No loaded scripts view

In my particular example I debugged 'launch vscode' configuration in our vscode repo.
I believe the issue here is that the chrome debug available on the marketplace still does not support loaded scripts.
@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Jul 31, 2018
@weinand
Copy link
Contributor

weinand commented Jul 31, 2018

@roblourens does the "Debugger for Chrome" already set the "supportsLoadedScriptRequest"?

@weinand weinand added the info-needed Issue requires more information from poster label Jul 31, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Jul 31, 2018

Looking here it seems like no
https://github.com/Microsoft/vscode-chrome-debug-core/blob/9afbe957503364d8d7b8225b1e890d59a65b4276/src/chrome/chromeDebugAdapter.ts#L277

@weinand weinand assigned roblourens and unassigned weinand Jul 31, 2018
@weinand weinand removed the info-needed Issue requires more information from poster label Jul 31, 2018
@roblourens roblourens added this to the July 2018 milestone Jul 31, 2018
@roblourens
Copy link
Member

Yeah I guess that should go in -core not node2

@JacksonKearl JacksonKearl added the verified Verification succeeded label Aug 2, 2018
@roblourens roblourens modified the milestones: July 2018, August 2018 Aug 2, 2018
@JacksonKearl JacksonKearl removed the verified Verification succeeded label Aug 2, 2018
@isidorn
Copy link
Contributor Author

isidorn commented Aug 28, 2018

I still see this with latest vscode insiders:

  1. vscode repo
  2. "launch vscode" configuration (uses chrome)
  3. Notice no loaded scripts view -> reopening

@isidorn isidorn reopened this Aug 28, 2018
@roblourens
Copy link
Member

Sorry, publishing it now.

@roblourens
Copy link
Member

This is published with the flag to enable it but needs #57401 to be fixed.

@isidorn isidorn added the verified Verification succeeded label Aug 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
August 2018
4 participants
@roblourens @weinand @isidorn @JacksonKearl