Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test built-in "LOADED SCRIPTS" view #57249

Closed
3 tasks done
weinand opened this issue Aug 27, 2018 · 2 comments
Closed
3 tasks done

Test built-in "LOADED SCRIPTS" view #57249

weinand opened this issue Aug 27, 2018 · 2 comments
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Aug 27, 2018

Complexity: 3
Ref: #55650

Authors: @weinand

We have moved the LoadedScripts view from node-debug into VS Code core.

In addition we have improved the way how the tree of loaded scripts is built by hiding all intermediate folder nodes if they only have one child.

Verify that:

  • loaded scripts are shown correctly for node and chrome debuggers,
  • multiple root folders are shown as an additional tree level if there are more than one,
  • multiple debug sessions add an additional level to the tree (which is not removed if the number of sessions drops to one again),
  • the new algorithm for minimising the number of folders with one child works and is useful,
  • find everything that is missing from the new implementation that make the LoadedScripts view behave differently than the VS Code explorer. E.g. hover, click behaviour, accessibility, etc.
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item labels Aug 27, 2018
@weinand weinand added this to the August 2018 milestone Aug 27, 2018
@weinand weinand changed the title Test builtin "LOADED SCRIPTS" view Test built-in "LOADED SCRIPTS" view Aug 27, 2018
@sandy081 sandy081 assigned dbaeumer and unassigned sandy081 Aug 28, 2018
@isidorn isidorn assigned isidorn and unassigned dbaeumer Aug 28, 2018
@isidorn isidorn removed their assignment Aug 28, 2018
@roblourens
Copy link
Member

It's not working well for me, I think just because of #57401. So I'll test tomorrow when that's fixed.

@roblourens
Copy link
Member

Tested with the private build

@roblourens roblourens reopened this Aug 29, 2018
@roblourens roblourens removed their assignment Aug 29, 2018
@alexdima alexdima removed their assignment Aug 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues testplan-item
Projects
None yet
Development

No branches or pull requests

6 participants