Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unverified breakpoint error with build 1.25 #53785

Closed
alanosman opened this issue Jul 7, 2018 · 21 comments
Closed

Unverified breakpoint error with build 1.25 #53785

alanosman opened this issue Jul 7, 2018 · 21 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded

Comments

@alanosman
Copy link

alanosman commented Jul 7, 2018

I was debugging server side nodejs code using the latest production build (version 1.25) and it was refusing to respect breakpoints that I set. I had just upgraded from 1.24 and debugging sessions where working fine before upgrading.

Breakpoints seem to set ok (i.e. you see the red circle) when the code is not running, but as soon as you start running, the breakpoint turns transparent and the code will not break execution.

Mousing over the breakpoint displays "Unverified breakpoint" in the tooltip.

I am using Windows 10, WSL/ubuntu environment with useWSL:true

Here's my launch.json

{
    "version": "0.2.0",
    "configurations": [
        {
            "type": "node",
            "protocol": "inspector",
            "request": "launch",
            "name": "Run Elastc",
            "program": "${workspaceFolder}/elastc.js",
            "useWSL": true,
        },
    ]
}

image

The fix is to revert back to 1.24 for now. You can get it from here:
https://code.visualstudio.com/updates/v1_24

:-(

@vscodebot
Copy link

vscodebot bot commented Jul 7, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@Ventajou
Copy link

Ventajou commented Jul 7, 2018

I'm seeing the same issue. I've reinstalled 1.24.1 and my breakpoints work again.
Some details on my setup:

  • Windows
  • code is TypeScript with sourcemaps
  • attaching the debugger to Node in a Docker container

@weinand weinand added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jul 7, 2018
@Alasano
Copy link

Alasano commented Jul 8, 2018

+1

  • Windows 10
  • useWSL set to true
  • runtimeExecutable is yarn

launch type request, used to work before upgrading today. App is regular 'ole nodejs with fancy flavor of the day JS frameworks.

@Finkes
Copy link

Finkes commented Jul 9, 2018

I have the same problem.
Mac OS X, Visual Studio Code 1.25

When using the debugger for NodeJS with Typescript my breakpoints don't get respected

launch.json

       {
            "name": "Start Server",
            "type": "node",
            "request": "launch",
            "program": "${workspaceRoot}/dist/server/start.js",
            "stopOnEntry": false,
            "outputCapture": "std",
            "args": [],
            "cwd": "${workspaceRoot}",
            "preLaunchTask": "compile",
            "runtimeArgs": [
                "--nolazy"
            ],
            "env": {
                "NODE_ENV": "development"
            },
            "sourceMaps": true,
            "outFiles": [
                "${workspaceRoot}/dist/server/**/*.js"
            ]
        },

I switched back to 1.24.1 and everything works fine again!

@mjknight50
Copy link

mjknight50 commented Jul 9, 2018

Same issue for me. I switched back to 1.24 and it is fine.
I am using Ubuntu 18.04 LTS.

launch.json

 {
            "type": "node",
            "request": "attach",
            "name": "Attach to Process",
            "port": 9229,
            "sourceMaps": true,
            "outFiles": ["${workspaceRoot}/dist/**/*.js"]
            
        }

tsconfig.json

{
  "compilerOptions": {
    "declaration": false,
    "noUnusedLocals": true,
    "emitDecoratorMetadata": true,
    "experimentalDecorators": true,
    "lib": [
      "es2017",
      "dom"
    ],
    "removeComments": false,
    "sourceMap": true,
    "mapRoot": "../dist/",
    "module": "commonjs",
    "moduleResolution": "node",
    "outDir": "../dist/",
    "target": "es2016",
    "allowJs": false,
    "typeRoots": [
      "../node_modules/@types"
    ],
    "baseUrl": "."
    
  }
}

@weinand weinand added this to the July 2018 milestone Jul 9, 2018
@weinand weinand added the bug Issue identified by VS Code Team member as probable bug label Jul 9, 2018
@alanosman alanosman changed the title Unverified breakpoint error seems to have returned Unverified breakpoint error with build 1.25 Jul 9, 2018
@roblourens
Copy link
Member

Can someone set "trace": true in your launch config, try it again, and upload the log here? Thanks

@roblourens
Copy link
Member

roblourens commented Jul 9, 2018

I think the log in #53891 is the same problem (would appreciate another one to confirm)

@roblourens roblourens added the candidate Issue identified as probable candidate for fixing in the next release label Jul 9, 2018
roblourens added a commit to microsoft/vscode-chrome-debug-core that referenced this issue Jul 9, 2018
@fxlemire
Copy link

fxlemire commented Jul 9, 2018

@roblourens
debugadapter.txt

@alanosman
Copy link
Author

thanks @fxlemire I was going to get to it, been busy today..

@roblourens
Copy link
Member

Thanks @fxlemire, same issue.

The fix will be in tomorrow's insiders, I'd appreciate if anyone tries it out.

roblourens added a commit that referenced this issue Jul 9, 2018
roblourens added a commit to microsoft/vscode-chrome-debug-core that referenced this issue Jul 9, 2018
@alanosman
Copy link
Author

@roblourens thanks for the quick turnaround.. will try it out tomorrow.

@fxlemire
Copy link

I confirm, it works on 1.26.0. Thanks for the quick fix @roblourens ❤️

@weinand
Copy link
Contributor

weinand commented Jul 10, 2018

@roblourens two users have confirmed that the fix solved the WSL issue #53674 too.

@weinand weinand removed their assignment Jul 10, 2018
@alanosman
Copy link
Author

alanosman commented Jul 10, 2018

Yup - fixed in insiders build:

Version: 1.26.0-insider
Commit: adfa9ce9778a6e79197477fcc60cb5420a31979a
Date: 2018-07-10T05:19:09.185Z

@alanosman
Copy link
Author

Will this make it to the next production release?

@roblourens
Copy link
Member

Great, thanks for verifying. Yes it will be in 1.25.1.

@RoyHP
Copy link

RoyHP commented Jul 10, 2018

Same issue here on 1.25.0, for all of my engineers

@roblourens
Copy link
Member

@RoyHP
Copy link

RoyHP commented Jul 19, 2018

This is still happening for us on 1.25.1 as it was on 1.25.0. Unverified breakpoints when debugging node remotely (via inspector protocol). No issue on 1.24.

Attached ss
screen shot 2018-07-19 at 5 06 51 pm
screen shot 2018-07-19 at 5 04 53 pm

@roblourens
Copy link
Member

@RoyHP please open a new issue and share your launch config. Would be helpful if you can set "trace": true, run it again, and attach the log.

@jaxxreal
Copy link

jaxxreal commented Aug 8, 2018

Hey @roblourens,

VSCode v1.25.1

Here is my launch config:

        {
            "name": "Attach",
            "type": "node",
            "request": "attach",
            "port": 9229,
            "address": "localhost",
            "restart": true,
            "sourceMaps": true,
            "outFiles": ["${workspaceRoot}/app/server/src"],
            "skipFiles": [
                "${workspaceFolder}/app/node_modules/**/*.js"
            ],
            "localRoot": "${workspaceRoot}/app/server/src",
            "remoteRoot": null,
            "smartStep": true,
            "trace": true
        },

And debugadapter.txt.

Thanks!

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests