Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Japanese Input (IME) on Mac - Suggestions Overlap w/ Text #45629

Closed
chibicode opened this issue Mar 13, 2018 · 19 comments · Fixed by #136097
Closed

Google Japanese Input (IME) on Mac - Suggestions Overlap w/ Text #45629

chibicode opened this issue Mar 13, 2018 · 19 comments · Fixed by #136097
Assignees
Labels
editor-input-IME Editor input of characters not on keyboard feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@chibicode
Copy link

chibicode commented Mar 13, 2018

  • VSCode Version: 1.21.0
  • OS Version: macOS 10.13.1

Steps to Reproduce:

  1. Install Google Japanese Input https://www.google.co.jp/intl/ja/ime/
  2. Activate it
  3. Open a new VSCode instance
  4. Type konnnichiha on keyboard, then hit enter, and do it again a few times
  5. Expected: the suggestions should never overlap w/ text. Actual: the suggestions overlap w/ text.

See the GIF:

screen recording 2018-03-12 at 08 03 pm

Does this issue occur when all extensions are disabled?: Yes

Notes:

This is not an issue with the default Japanese IME that comes w/ macOS.


Update (Sep 27, 2018): Workaround

This setting seems to fix the issue. (You'll lose some functionalities)

@Yamotty
Copy link

Yamotty commented Mar 13, 2018

Same Here

@mashriq
Copy link

mashriq commented Mar 13, 2018

same here

@CM-Kajiwara
Copy link

Same Here

@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Mar 13, 2018

@jrieken The suggestion box that shows up in this case is not the one for suggestWidget. This seems like a native control which I dont believe VS Code controls

cc @rebornix @octref

@chibicode @Yamotty @mashriq @CM-Kajiwara Is this a regression? Did this work as expected in earlier versions of VS Code and stopped working recently?

@rebornix
Copy link
Member

I think it is probably caused by the position adjustment of the textarea, Google IME tries to put the candidate list at the proper position, but I don't have a stable reproduce yet.

@rebornix rebornix assigned rebornix and alexdima and unassigned ramya-rao-a Mar 13, 2018
@rebornix rebornix added the editor-input-IME Editor input of characters not on keyboard label Mar 13, 2018
@chibicode
Copy link
Author

Sorry, I am a new user to VSCode so not sure if this is a regression.

@octref
Copy link
Contributor

octref commented Mar 13, 2018

@rebornix I can repro it consistently.

image

@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Mar 29, 2018
@chibicode
Copy link
Author

chibicode commented Jul 23, 2018

Not just VSCode but Adobe Brackets seems to have the same issue as well - and for that, apparently, the issue is on CodeMirror:
codemirror/codemirror5#4089

If it's an Electron issue not sure if upgrading Electron to 2.x or 3.x fixes it. #45542

This was not an issue on Atom (even when Atom was using Electron 1.x).

@chibicode
Copy link
Author

I also searched through Twitter, and people have been reporting this since April 2015. Definitely not a regression. @ramya-rao-a @rebornix

https://twitter.com/shohaga/status/593568407301193728
https://twitter.com/hiedar83/status/593676327665860608
https://twitter.com/tyamaz/status/593728561392984064

@hiramatsu
Copy link

Same Here

@rebornix

2018-08-24 12 03 06
2018-08-24 12 03 35

@chibicode
Copy link
Author

chibicode commented Sep 5, 2018

@rebornix @octref Is there anything I can do to help?

Also saw this reported on Teratail, a Japanese Stackoverflow clone, about a week ago.
https://teratail.com/questions/143100

@hiramatsu
Copy link

※日本語で失礼します。

暫定的(temporary)な回避策(workaround)ですが、「Google 日本語入力 環境設定」の「サジェスト」タブの
・入力履歴からのサジェスト自動表示を有効にする
・リアルタイム変換を有効にする
のチェックを外せば被らなくなりました。(上記機能は失われますが…)
2018-09-26 11 51 35

@chibicode
Copy link
Author

chibicode commented Sep 26, 2018

Translating what @hiramatsu said:

Temporary workaround: go to Google Japanese Input preferences,

screen shot 2018-09-26 at 6 58 30 pm

go to サジェスト ("suggest") and uncheck

  • 入力履歴からのサジェスト自動表示を有効にする (disable suggestion from input history)
  • リアルタイム変換を有効にする (disable live conversion)

Then click 適用 button at the bottom.

Then it no longer overlaps.

@rebornix
Copy link
Member

@hiramatsu @chibicode thanks for your help. This issue was caused by how we implement our editor (virtualize everything but has a tiny textarea around the virtual cursor) and Google IME doesn't work the same as the OS builtin IME. I don't have a good idea how to hint Google IME about the position but your solution works perfectly for this issue.

For anyone who is using English as system language, the preference with the workaround will look like below:

image

@rebornix rebornix added this to the Backlog milestone Sep 26, 2018
@rebornix rebornix removed their assignment Sep 26, 2018
@rebornix rebornix added the help wanted Issues identified as good community contribution opportunities label Sep 26, 2018
@chibicode
Copy link
Author

@rebornix thanks for the follow-up!

Just for completeness: Google maintains "a subset of Google Japanese Input in the form of source code under OSS license without any warranty nor user support" at google/mozc (more explanation), though they're not accepting pull requests at the moment.

@yujikuroki
Copy link

Same here

@jedipunkz
Copy link

same here

@zkwhandan
Copy link

zkwhandan commented Jul 21, 2019

same here
OS: windows 10
Language: Chinese
IME: Sogou Pinyin, Baidu Pinyin
无标题

@alexdima alexdima added the macos Issues with VS Code on MAC/OS X label Aug 8, 2019
@rebornix rebornix added *question Issue represents a question, should be posted to StackOverflow (VS Code) and removed bug Issue identified by VS Code Team member as probable bug labels Nov 6, 2020
@rebornix rebornix reopened this Nov 6, 2020
@alexdima alexdima added feature-request Request for new features or functionality and removed *question Issue represents a question, should be posted to StackOverflow (VS Code) labels Nov 20, 2020
@alexdima alexdima removed the help wanted Issues identified as good community contribution opportunities label Oct 29, 2021
@alexdima alexdima self-assigned this Oct 29, 2021
@alexdima alexdima modified the milestones: Backlog, October 2021 Oct 29, 2021
alexdima added a commit that referenced this issue Oct 29, 2021
@alexdima alexdima modified the milestones: October 2021, November 2021 Oct 29, 2021
@alexdima alexdima removed their assignment Oct 29, 2021
@alexdima alexdima self-assigned this Nov 30, 2021
@alexdima alexdima added the verification-needed Verification of issue is requested label Nov 30, 2021
@rzhao271 rzhao271 added the verified Verification succeeded label Dec 1, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
editor-input-IME Editor input of characters not on keyboard feature-request Request for new features or functionality insiders-released Patch has been released in VS Code Insiders macos Issues with VS Code on MAC/OS X verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

15 participants