Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer: restore focus to last view that had focus #41377

Closed
bpasero opened this issue Jan 10, 2018 · 4 comments
Closed

Explorer: restore focus to last view that had focus #41377

bpasero opened this issue Jan 10, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jan 10, 2018

Somehow we lost the support in the explorer to restore the focus to the view that last had focus. I remember I added code once to restore focus to either "Open Editors" or "Files Explorer" when clicking on the Explorer viewlet to open it again depending on where focus was last.

Worse, today when the "Files Explorer" is collapsed, the focus does not go to anything within the explorer:

image

Not sure if this is related but I am seeing a similar issue with the SCM viewlet: When focus is in the changes view input box and I click to another viewlet and back, the focus is not restored there, even though it looks like PanelViewlet has a concept of lastFocusedPanel

@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues labels Jan 10, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 10, 2018

I believe this behavior should be built into the split view and shared across vscode. Writhing explorer specific code does not make much sense to me
Thus assigning to @sandy081 and @joaomoreno

@isidorn isidorn assigned joaomoreno and sandy081 and unassigned isidorn Jan 10, 2018
@bpasero bpasero added layout General VS Code workbench layout issues and removed file-explorer Explorer widget issues labels Jan 10, 2018
@sandy081 sandy081 added this to the January 2018 milestone Jan 10, 2018
@sandy081
Copy link
Member

I will take a look

@bpasero
Copy link
Member Author

bpasero commented Jan 30, 2018

@sandy081 seems to work fine for explorer now, but should this also work in other views like Debug and SCM?

@sandy081
Copy link
Member

Debug and SCM viewlets override to have specific focus behaviour. @isidorn @joaomoreno FYI

@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants