Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support opening workspace as a new native tab in existing window from CLI #27305

Closed
RoarkeRandall opened this issue May 25, 2017 · 5 comments
Closed
Labels
electron Issues and items related to Electron feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-os-integration Native OS integration issues workbench-window Window management

Comments

@RoarkeRandall
Copy link

  • VSCode Version: Version 1.12.2 (1.12.2)
  • OS Version: 10.12.1

Steps to Reproduce:

  1. Have a window open with multiple workspaces open as a native tab
  2. In a terminal, cd to a new workspace location.
  3. Run code .

I would expect that if you are using native tabs, the workspace should open as a new tab in the last used vscode window. Currently it will open a new window. The -r and -n options don't work. -r will replace one of the currently open tabs and -n will create a new window.

@roblourens roblourens added the feature-request Request for new features or functionality label May 26, 2017
@bpasero
Copy link
Member

bpasero commented May 26, 2017

@RoarkeRandall maybe check your tab settings in the OS:

image

@bpasero bpasero removed their assignment May 26, 2017
@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench labels May 26, 2017
@RoarkeRandall
Copy link
Author

Hey @bpasero, I already have those settings relating to tabs.

@PSalant726
Copy link

PSalant726 commented Oct 25, 2017

@RoarkeRandall with the above setting mentioned by bpasero and "window.nativeTabs": true in your User Settings JSON, the code . command will open a new native tab.

I am experiencing this issue #35361, where the tab bar does not show the native tabs, but this is a known regression for the 1.17.2 release.

@bpasero bpasero added electron Issues and items related to Electron workbench-os-integration Native OS integration issues workbench-electron Electron-VS Code issues and removed workbench labels Nov 16, 2017
@RoarkeRandall
Copy link
Author

Any luck with this? It's kinda odd. I had it working for awhile, but after the upgrade to 1.19.0 and messing with my settings a little (un-related to native tabs though) this behavior started up again.

@bpasero bpasero added workbench-window Window management and removed workbench-electron Electron-VS Code issues labels Aug 6, 2018
@bpasero
Copy link
Member

bpasero commented Aug 27, 2018

I feel like this should be driven by the macOS options as outlined in #27305 (comment) and not via a CLI argument. Closing - the issues around rendering native tabs are all resolved by now.

@bpasero bpasero closed this as completed Aug 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
electron Issues and items related to Electron feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) workbench-os-integration Native OS integration issues workbench-window Window management
Projects
None yet
Development

No branches or pull requests

4 participants