Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

macOS Native Tabs not restored when restarting app #27222

Closed
beeing opened this issue May 25, 2017 · 4 comments
Closed

macOS Native Tabs not restored when restarting app #27222

beeing opened this issue May 25, 2017 · 4 comments
Labels
electron Issues and items related to Electron feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream workbench-os-integration Native OS integration issues
Milestone
Backlog

Comments

@beeing
Copy link

beeing commented May 25, 2017

  • VSCode Version: 1.12.2
  • OS Version: macOS 10.12.5

Steps to Reproduce:

  1. Create few windows and drag the tab headers to create a tabbed in one window
  2. Quit vscode
  3. Run vscode and noticed each native tabs becomes a separate window
@bpasero bpasero self-assigned this May 25, 2017
@bpasero bpasero added electron Issues and items related to Electron upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels May 25, 2017
@bpasero bpasero added this to the Backlog milestone May 25, 2017
@abdel-ships-it
Copy link

This issue is definitely a pain in the ass, I always wind up having many projects opened. And once vscode crashes or requires a restart, I have to open all of them all over again.

@PSalant726
Copy link

PSalant726 commented Oct 25, 2017 •
edited
Loading

I believe this issue can be resolved with the setting mentioned here, as well as "window.nativeTabs": true in the User Settings JSON.

@bpasero bpasero added workbench feature-request Request for new features or functionality and removed workbench labels Nov 12, 2017
@bpasero bpasero removed their assignment Nov 14, 2017
@bpasero bpasero added the workbench-os-integration Native OS integration issues label Nov 14, 2017
@bpasero bpasero removed this from the Backlog milestone Nov 18, 2017
@bpasero
Copy link
Member

bpasero commented May 3, 2019

Depends on electron/electron#18138 for the full solution.

As mentioned in #27222 (comment), you can get at least all windows grouped together into native tabs by:

  • configuring "window.nativeTabs": true and "window.restoreWindows": "all" inside VSCode
  • setting the Dock preferences on macOS to open windows always as a tab ("Prefer tabs when opening documents: Always)

image

@bpasero bpasero added the upstream-issue-linked This is an upstream issue that has been reported upstream label Oct 10, 2019
@bpasero bpasero added this to the Backlog milestone Oct 24, 2019
@bpasero
Copy link
Member

bpasero commented Nov 4, 2020

Since this issue has a linked upstream issue referenced, I am going ahead to close this issue as part of our issue grooming effort: https://github.com/microsoft/vscode/wiki/Issue-Grooming

@bpasero bpasero closed this as completed Nov 4, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
electron Issues and items related to Electron feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) upstream-issue-linked This is an upstream issue that has been reported upstream workbench-os-integration Native OS integration issues
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@bpasero @abdel-ships-it @PSalant726 @beeing