Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error while playing sound DOMException: play() can only be initiated by a user gesture #197937

Closed
joyceerhl opened this issue Nov 10, 2023 · 4 comments · Fixed by #197951
Closed

Error while playing sound DOMException: play() can only be initiated by a user gesture #197937

joyceerhl opened this issue Nov 10, 2023 · 4 comments · Fixed by #197951
Assignees
@deepak1556 @meganrogge
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Milestone
November 2023

Comments

@joyceerhl
Copy link
Contributor

  1. Enable screen reader optimized mode
  2. Use VS Code for a bit (I think I ran some commands in the terminal)
  3. Open dev tools, see this error
Error while playing sound DOMException: play() can only be initiated by a user gesture.
playSound @ audioCueService.ts:125
@meganrogge
Copy link
Contributor

I couldn't find the issue, but think there's one tracking this.

This was fixed with #179204 and then reverted because we don't want to enable autoplay of media as it has implications beyond audio cues.

@meganrogge meganrogge added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Nov 10, 2023
@meganrogge
Copy link
Contributor

It will play if we try to run the chat response finished audio cue for example and more than X seconds have elapsed since the user's gesture.

@meganrogge
Copy link
Contributor

Thus far, I've not been catching that error because it's been useful to diagnose user's issues with audio cues not playing, but I think maybe we should at this point, since they're more stable now.

@meganrogge
Copy link
Contributor

We will not log this error, given the solution to it is unclear and we're tracking the issue #178642

meganrogge added a commit that referenced this issue Nov 10, 2023
@meganrogge
fix #197937
73f87ec
@meganrogge meganrogge mentioned this issue Nov 10, 2023
Merged
@vscodenpa vscodenpa added the unreleased Patch has not yet been released in VS Code Insiders label Nov 10, 2023
@vscodenpa vscodenpa added this to the November 2023 milestone Nov 10, 2023
@vscodenpa vscodenpa added insiders-released Patch has been released in VS Code Insiders and removed unreleased Patch has not yet been released in VS Code Insiders labels Nov 13, 2023
@rzhao271 rzhao271 added the verified Verification succeeded label Nov 29, 2023
@CareyJWilliams CareyJWilliams mentioned this issue Jun 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepak1556 deepak1556

@meganrogge meganrogge

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug insiders-released Patch has been released in VS Code Insiders verified Verification succeeded
Projects
None yet
Milestone
November 2023
Development

Successfully merging a pull request may close this issue.

do not log audio cue error, we're tracking the issue microsoft/vscode
5 participants
@deepak1556 @rzhao271 @meganrogge @joyceerhl @vscodenpa