-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audio autoplay does not work in Notebook renderers #178642
Comments
@deepak1556 @mjbvz /cc Above is a sample file that you can just open in VS Code, no need of any extensions. Also, the output is plain HTML, nothing specific to jupyter. |
Untitled.mp4video of reproduction after disabling extensions in case it helps |
@DonJayamanne Autoplay typically requires user interaction. We may be able to workaround this though for the notebook iframe: https://developer.mozilla.org/en-US/docs/Web/Media/Autoplay_guide#autoplay_availability A little wary though of just enabling autoplay by default. Definitely should only be done for trusted notebooks I also wonder if this PR would fix this: #179204? |
I haven't tested, but believe #179204 would fix it. I wonder if we should have a setting (off by default) for this? |
Is it possible to display a warning message in the HTML (above audio element) indicating the fact that the audio hasn't been auto-played and could be enabled via a setting (this way users know what is going on and can easily discovery the setting and change it if they want). |
It is tricky to resolve this, requires a new API from the runtime to override the autoplay policy of a particular frame, isolate the notebooks to a different origin. Also the solution cannot work for the web version, closing as not actionable. |
Applies To
What happened?
Audio isn't autoplaying
Code_WWj9qOWSCM.mp4
Possibly related:
microsoft/vscode-jupyter#1012 (comment)
VS Code Version
Version: 1.76.2 (system setup) Commit: ee2b180 Date: 2023-03-14T17:55:54.936Z Electron: 19.1.11 Chromium: 102.0.5005.196 Node.js: 16.14.2 V8: 10.2.154.26-electron.0 OS: Windows_NT x64 10.0.19045 Sandboxed: No
Jupyter Extension Version
Name: Jupyter Id: ms-toolsai.jupyter Description: Jupyter notebook support, interactive programming and computing that supports Intellisense, debugging and more. Version: 2023.2.1200692131 Publisher: Microsoft VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-toolsai.jupyter
Jupyter logs
Coding Language and Runtime Version
Python 3.10.9
Language Extension Version (if applicable)
Name: Python
Id: ms-python.python
Description: IntelliSense (Pylance), Linting, Debugging (multi-threaded, remote), Jupyter Notebooks, code formatting, refactoring, unit tests, and more.
Version: 2023.4.1
Publisher: Microsoft
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=ms-python.python
Anaconda Version (if applicable)
conda 22.11.1
Running Jupyter locally or remotely?
Local
The text was updated successfully, but these errors were encountered: