Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a "TypeHierarchyProvider" api for visualising type hierarchies #15533

Closed
DanTup opened this issue Nov 15, 2016 · 8 comments
Closed

Create a "TypeHierarchyProvider" api for visualising type hierarchies #15533

DanTup opened this issue Nov 15, 2016 · 8 comments
Assignees
Labels
api api-finalization editor-symbols definitions, declarations, references feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes typehierarchy verification-needed Verification of issue is requested verified Verification succeeded

Comments

@DanTup
Copy link
Contributor

DanTup commented Nov 15, 2016

(Split from #15485)

Dart Code has had requests for viewing/navigating type hierarchies. We've implemented this for now using the pick-list, but we had to make compromises to fit it into a flat list.

Some other editors have this functionality and it's a concept that's not specific to Dart, so it might make sense as a provider that can be implemented by extensions.

Here's an image of it in another editor and also how we've managed to implement it currently.

687474703a2f2f68656c702e65636c697073652e6f72672f6e656f6e2f746f7069632f6f72672e65636c697073652e6a64742e646f632e757365722f67657474
c26454f6-8e17-11e6-9df1-046930178341

@fwcd
Copy link
Contributor

fwcd commented Jun 21, 2018

Any progress on this one? I would really love to have this feature in VSCode.

@KamasamaK
Copy link

@fwcd Not for VS Code native yet, but there has been recent activity on the LSP implementation at microsoft/vscode-languageserver-node#426, which when completed generally translates into a very similar native API. Of course, there's also a matter of the UI.

@tomhanax
Copy link

We have call hierarchy now, which is perfect. How it is going with type hierarchy? This is IMHO somewhat essential functionality in typed languages like TypeScript, Java...

@akaroml
Copy link
Member

akaroml commented Apr 20, 2020

+1 from Java perspective. Type Hierarchy is also super useful for Java users.

@jrieken
Copy link
Member

jrieken commented Jul 19, 2021

fyi - we do have an API proposal for this, the LSP counter part is quite far already, and the UI is being worked on:

//#region https://github.com/microsoft/vscode/issues/15533 --- Type hierarchy --- @eskibear

jrieken added a commit that referenced this issue Jul 19, 2021
AiverReaver pushed a commit to AiverReaver/vscode that referenced this issue Aug 19, 2021
@jrieken jrieken closed this as completed Aug 23, 2021
@jrieken jrieken added on-testplan on-release-notes Issue/pull request mentioned in release notes labels Aug 23, 2021
@jrieken
Copy link
Member

jrieken commented Sep 1, 2021

Keeping this issue open to finalize the API

@jrieken
Copy link
Member

jrieken commented Sep 13, 2021

Done. The API is now finalized, there is "Peek Type Hierarchy" and "Show Type Hierarchy" command. Special thanks to @Eskibear who did all of this 👏

@jrieken jrieken closed this as completed Sep 13, 2021
utajum pushed a commit to utajum/vscode that referenced this issue Sep 13, 2021
@jrieken jrieken added the verification-needed Verification of issue is requested label Sep 27, 2021
@jrieken
Copy link
Member

jrieken commented Sep 27, 2021

To verify make sure that latest1 vscode.d.ts contains vscode.languages.registerTypeHierarchyProvider and that it is fully documented

1 find latest vscode.d.ts in our repo or use npx vscode-dts main to download it into the current folder

@lramos15 lramos15 added the verified Verification succeeded label Sep 28, 2021
@jrieken jrieken added the on-release-notes Issue/pull request mentioned in release notes label Sep 30, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api api-finalization editor-symbols definitions, declarations, references feature-request Request for new features or functionality on-release-notes Issue/pull request mentioned in release notes typehierarchy verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

7 participants