Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeHierarchyProvider doc is unclear about depth of super/subtypes to return #132117

Closed
gjsjohnmurray opened this issue Sep 2, 2021 · 2 comments
Closed

TypeHierarchyProvider doc is unclear about depth of super/subtypes to return #132117

gjsjohnmurray opened this issue Sep 2, 2021 · 2 comments
Assignees
@jrieken
Labels
polish Cleanup and polish issue typehierarchy

Comments

@gjsjohnmurray
Copy link
Contributor

Issue Type: Bug

Should provideTypeHierarchySupertypes return only immediate supertypes (i.e. the ones named in an Extends clause), or all supertypes in the hierarchy?

Ditto for provideTypeHierarchySubtypes

Relates to #15533

VS Code version: Code - Insiders 1.60.0-insider (e7d7e9a, 2021-09-01T10:40:58.134Z)
OS version: Windows_NT x64 10.0.19043
Restricted Mode: No
@jrieken jrieken added polish Cleanup and polish issue typehierarchy labels Sep 3, 2021
@isc-bsaviano
Copy link

It would be great to get more clarification on this before the API is released.

@jrieken
Copy link
Member

jrieken commented Sep 13, 2021

We have done that

@jrieken jrieken closed this as completed Sep 13, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
polish Cleanup and polish issue typehierarchy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jrieken @gjsjohnmurray @isc-bsaviano