-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Reopen folder using..." should use a more dedicated ux solution, not notifications #121805
Comments
Assigning @bpasero for code-workspace notification. |
The explorer is not empty in this case though, we just scan the top level files of the folder for workspace files. I am not sure where to put such a button then? |
@isidorn btw I think the 2 notifications do not really have something in common right, should there be 2 issues then? |
@bpasero oh they have in common that they are offering to reopen the folder based on some file in the workspace. So I think maybe they can be solved with the same UX. I do understand that the Explorer is not empty, but most of the time there is extra space at the bottom of the explorer and maybe we could render some buttons / banner there. Just an idea. |
We should look at telemetry data to see how many people use the "Reopen in Container" action from the toast. This is more of a discoverability item where we let the user know that they CAN open it in a container if they'd like. I'd be ok removing the toast and using the remote indicator or command palette but not sure if that'd impact the usability of it. cc @Chuxel @bamurtaugh for feedback within the Containers extension. |
@misolori Personally, this is the main way I use the extension. Its logically similar to the workspace notification raising awareness to the presence of a code-workspace file. Is the proposal to remove both? In my view, the core issue here is that both of these are things that you discover after cloning a repository and opening it. We'd want a similar solution. The dev container one has the additional disadvantage of not being in the file menu, so the primary way I personally get into one is to first type "code ." or use the normal file menu and then "reopen". Speaking for myself, I never use "Open Folder in Container." Brigit may have some additional data. |
I just spent some time looking through notification data, but I can't seem to discern which notification is which. I could discern if users took an action, which action they took, but I'm not sure what % of users were presented that notification/completed the action out of the total # of notifications. Based on action labels alone, it looks like "Reopen in Container" has a notable lead in clicks over "Don't Show Again" (I want to be conscious of listing exact numbers in a public issue - not sure what's ok to post?). My primary flow is the same as Chuck's - I open a project containing a dev container (either through the file menu, from the WSL file system, or code .), then reopen in a dev container. I usually use the reopen prompt, but occasionally the command. I essentially never use "Open Folder in Container" either. When I look at the commands executed from Remote-Containers (since the notification is backed by the same command coming from the Command Palette), the number of folks using Open Folder and Reopen in Container appears about equal (again, not sure how precise I can be in a public issue?). I was a bit surprised to see the equal distribution of Open Folder and Reopen in Container (since I anticipated more user action would come from Reopen as it also has a prompt), so perhaps user behavior is a bit different than our own. |
Thanks for sharing your thoughts. From your comments it seems like you LIKE having an easy way to click on a button somewhere and the workspace reopens in the appropriate setting. I think this flow makes perfect sense, I am just arguing that maybe that button should not be in a notification, but maybe the explorer or some other place. Even we do not figure out a better ux, at the very minimum we should polish the "Do Not Show Again" flow for containers which uses 1 extra notification it seems. Idea: |
I agree we could polish the "Do Not Show Again" flow for containers - it feels a bit counterintuitive to select you don't want anymore notifications, and then are immediately shown another one. One option is for us to make the decision for the user. Looking at data, more users choose "Current Folder" than "Any Folder," so we could default to "Current Folder." But perhaps we could optimize the wording or flow further since this wouldn't necessarily be clear (i.e. if I select "Do Not Show Again" in one folder and see it again in another, I might be confused). It could be interesting to run an A/B experiment to see if a badge or notification for Remote-Containers is more engaging (although experiments don't convey user sentiment around notification flow/overload). Badges could be useful for something like the Remote-WSL recommender too - help draw user attention to the remote indicator since they may not be aware something was installed/anything changed/they should take an action. |
@bamurtaugh I like that point for just choosing the "Current Folder" automatically! |
For may there are no plans to change anything here after discussing in the UX meeting. For that leaving this one assigned to @chrmarti |
Refs: #119463
Currently we have mulitple experience to reopen the folder because there is a
Dev Container
file or a.code-workspace
file. Both of them use notifications in order to make the user aware of this.Instead of this I propose the following:
fyi @misolori @bpasero for ideas
The text was updated successfully, but these errors were encountered: